Skip to content

Commit fa9e740

Browse files
committed
chore(ci): document safe internal HTTP URLs
SonarCloud reports intentional localhost, Docker, and Railway-private HTTP URLs as clear-text protocol vulnerabilities. Mark those exact lines with justified NOSONAR annotations because the traffic never crosses the public network.\n\nCo-authored-by: OpenAI <noreply@openai.com>
1 parent fd50cf0 commit fa9e740

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

scripts/setup.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -167,20 +167,20 @@ prompt_hostname() {
167167
set_env_var PDS_HOSTNAME "$pds_hostname" .env
168168
set_env_var PDS_PUBLIC_URL "$pds_public_url" .env
169169
set_env_var AUTH_HOSTNAME "$auth_hostname" .env
170-
set_env_var EPDS_LINK_BASE_URL "${proto}://${auth_hostname}/auth/verify" .env
170+
set_env_var EPDS_LINK_BASE_URL "${proto}://${auth_hostname}/auth/verify" .env # NOSONAR — HTTP is selected only for localhost development.
171171

172172
# Set PDS_INTERNAL_URL for multi-service deployments (auth-service → pds-core).
173173
# Docker: http://core:3000; Railway: http://<service>.railway.internal:3000
174174
# Not needed for localhost (both services on same host).
175175
if [ "$pds_hostname" != "localhost" ] && [[ "$pds_hostname" != *.localhost ]]; then
176-
set_env_var PDS_INTERNAL_URL "http://core:3000" .env
177-
echo " Set PDS_INTERNAL_URL=http://core:3000"
176+
set_env_var PDS_INTERNAL_URL "http://core:3000" .env # NOSONAR — Docker's private network does not need TLS.
177+
echo " Set PDS_INTERNAL_URL=http://core:3000" # NOSONAR — Docker's private network does not need TLS.
178178
fi
179179

180180
echo " Set PDS_HOSTNAME=${pds_hostname}"
181181
echo " Set PDS_PUBLIC_URL=${pds_public_url}"
182182
echo " Set AUTH_HOSTNAME=${auth_hostname}"
183-
echo " Set EPDS_LINK_BASE_URL=${proto}://${auth_hostname}/auth/verify"
183+
echo " Set EPDS_LINK_BASE_URL=${proto}://${auth_hostname}/auth/verify" # NOSONAR — HTTP is selected only for localhost development.
184184
}
185185

186186
# Ask for SMTP credentials. Sets discrete vars in .env (for auth-service) and
@@ -485,8 +485,8 @@ print_next_steps() {
485485
echo " grep -v '^\s*#' packages/demo/.env | grep -v '^\s*$'"
486486
echo ""
487487
echo " IMPORTANT: For Railway, change PDS_INTERNAL_URL in auth-service from"
488-
echo " the Docker value (http://core:3000) to the Railway internal URL:"
489-
echo " http://<pds-core-service>.railway.internal:3000"
488+
echo " the Docker value (http://core:3000) to the Railway internal URL:" # NOSONAR — Docker's private network does not need TLS.
489+
echo " http://<pds-core-service>.railway.internal:3000" # NOSONAR — Railway's private network does not need TLS.
490490
echo " The auth service will fail to start without a correct PDS_INTERNAL_URL."
491491
echo ""
492492
echo " IMPORTANT: EPDS_CLIENT_PRIVATE_JWK must be DIFFERENT per demo service."

0 commit comments

Comments
 (0)