Skip to content

Commit 0159c55

Browse files
aspiersclaude
andcommitted
fix(permissions): remove app.certified.signature.proof from the Certified set
app.certified.signature.proof does not exist as a record lexicon on main — it is added by PR #219 (feat/signature-support-v2, HYPER-181). Including it here made app.certified.permissions.crud reference a non-existent collection (correctly flagged in review). Drop it, leaving the 8 app.certified.* record collections that actually exist on main. Documents in the Maintenance section that the set must gain app.certified.signature.proof once #219 merges. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 7b80639 commit 0159c55

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

docs/design/permission-sets.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ Enumerates every `type: "record"` collection under `app.certified.*`:
150150
"app.certified.graph.follow",
151151
"app.certified.link.evm",
152152
"app.certified.location",
153-
"app.certified.signature.proof",
154153
],
155154
"action": ["create", "update", "delete"],
156155
},
@@ -267,6 +266,15 @@ new collection will be silently uncovered by the set. Worth a check in the
267266
release process (and ideally an automated test asserting each set lists exactly
268267
the `type: "record"` defs in its namespace).
269268

269+
> **Known pending update.** PR
270+
> [#219](https://github.com/hypercerts-org/hypercerts-lexicon/pull/219)
271+
> (`feat/signature-support-v2`, HYPER-181) adds the `app.certified.signature.proof`
272+
> record lexicon, which does **not** exist on `main` yet and so is **not** in
273+
> `app.certified.permissions.crud` here. When #219 merges,
274+
> `app.certified.signature.proof` must be added to the set's `collection` list
275+
> (and re-published). The two PRs touch different files, so neither blocks the
276+
> other — this is just a follow-up to land after both.
277+
270278
## References
271279

272280
- AT Protocol permission spec — permission sets:

lexicons/app/certified/permissions/crud.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919
"app.certified.badge.response",
2020
"app.certified.graph.follow",
2121
"app.certified.link.evm",
22-
"app.certified.location",
23-
"app.certified.signature.proof"
22+
"app.certified.location"
2423
],
2524
"action": ["create", "update", "delete"]
2625
}

0 commit comments

Comments
 (0)