Skip to content

Commit a85808f

Browse files
committed
test: rename validate-signatures-on-record to validate-signature-defs
Align with the per-lexicon naming convention in AGENTS.md ("one file per lexicon, named validate-<lexicon-slug>.test.ts"). The tests cover the array def at app.certified.signature.defs#list (open union of inline + strongRef, optional/empty/mixed array semantics), so signature-defs is the lexicon under test. Activity is just the representative carrier — all 19 record lexicons share the same def. Addresses CodeRabbit feedback on PR #170.
1 parent 1c793db commit a85808f

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

tests/validate-signatures-on-record.test.ts renamed to tests/validate-signature-defs.test.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ import { ids } from "../generated/lexicons.js";
33
import * as Activity from "../generated/types/org/hypercerts/claim/activity.js";
44

55
/**
6-
* Tests that the `signatures` property works correctly on record lexicons.
7-
* Uses activity as a representative — all 20 record lexicons share the
8-
* same signatures property definition.
6+
* Tests the `app.certified.signature.defs#list` array def — specifically
7+
* its union semantics (inline signature + strongRef) and array-level
8+
* behavior (optional, empty, mixed). Uses activity as a representative
9+
* carrier; all 19 record lexicons reference the same def.
910
*/
10-
describe("signatures property on records", () => {
11+
describe("app.certified.signature.defs#list (via activity carrier)", () => {
1112
const baseActivity = {
1213
title: "Test Activity",
1314
shortDescription: "A test activity for signature validation",

0 commit comments

Comments
 (0)