Revert "NON-BREAKING: [HYPER-181] add cryptographic signature support to all lexicons" by s-adamantine · Pull Request #216 · hypercerts-org/hypercerts-lexicon

s-adamantine · 2026-05-21T17:15:25Z

Reverts #170

Summary by CodeRabbit

Release Notes

Revert
- Removed cryptographic signature support. Records across all lexicons can no longer carry optional cryptographic signatures for attestation and verification purposes.
Chores
- Removed signature validation tests and related test utilities.
- Updated documentation to reflect the removal of signature capabilities.
- Adjusted project dependencies.

… to all lexicons"

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

changeset-bot · 2026-05-21T17:15:30Z

⚠️ No Changeset found

Latest commit: 897201b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-05-21T17:16:04Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b6af8d90-7f6d-4d04-a1c1-67a836bd5da9

📥 Commits

Reviewing files that changed from the base of the PR and between 478f5be and 897201b.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (35)

.agents/skills/building-with-hypercerts-lexicons/SKILL.md
.changeset/add-signature-support.md
.gitignore
AGENTS.md
ERD.puml
README.md
SCHEMAS.md
lexicons/app/certified/actor/organization.json
lexicons/app/certified/actor/profile.json
lexicons/app/certified/badge/award.json
lexicons/app/certified/badge/definition.json
lexicons/app/certified/badge/response.json
lexicons/app/certified/graph/follow.json
lexicons/app/certified/link/evm.json
lexicons/app/certified/location.json
lexicons/app/certified/signature/defs.json
lexicons/app/certified/signature/proof.json
lexicons/org/hyperboards/board.json
lexicons/org/hyperboards/displayProfile.json
lexicons/org/hypercerts/claim/activity.json
lexicons/org/hypercerts/claim/contribution.json
lexicons/org/hypercerts/claim/contributorInformation.json
lexicons/org/hypercerts/claim/rights.json
lexicons/org/hypercerts/collection.json
lexicons/org/hypercerts/context/acknowledgement.json
lexicons/org/hypercerts/context/attachment.json
lexicons/org/hypercerts/context/evaluation.json
lexicons/org/hypercerts/context/measurement.json
lexicons/org/hypercerts/funding/receipt.json
lexicons/org/hypercerts/workscope/tag.json
package.json
tests/validate-signature-defs-inline.test.ts
tests/validate-signature-defs.test.ts
tests/validate-signature-proof.test.ts
tests/validate-signing-example.test.ts

💤 Files with no reviewable changes (31)

.gitignore
lexicons/org/hyperboards/board.json
lexicons/app/certified/signature/defs.json
tests/validate-signature-defs-inline.test.ts
tests/validate-signature-proof.test.ts
tests/validate-signature-defs.test.ts
lexicons/org/hypercerts/funding/receipt.json
lexicons/org/hypercerts/claim/contribution.json
lexicons/org/hypercerts/context/evaluation.json
lexicons/app/certified/badge/definition.json
lexicons/org/hyperboards/displayProfile.json
lexicons/app/certified/signature/proof.json
ERD.puml
lexicons/app/certified/location.json
lexicons/org/hypercerts/collection.json
lexicons/org/hypercerts/context/measurement.json
tests/validate-signing-example.test.ts
lexicons/app/certified/badge/response.json
lexicons/app/certified/link/evm.json
lexicons/app/certified/badge/award.json
lexicons/app/certified/graph/follow.json
lexicons/app/certified/actor/profile.json
lexicons/org/hypercerts/claim/rights.json
lexicons/app/certified/actor/organization.json
lexicons/org/hypercerts/claim/contributorInformation.json
lexicons/org/hypercerts/context/acknowledgement.json
lexicons/org/hypercerts/context/attachment.json
.changeset/add-signature-support.md
lexicons/org/hypercerts/workscope/tag.json
lexicons/org/hypercerts/claim/activity.json
README.md

📝 Walkthrough

Walkthrough

This PR removes cryptographic signature support from the hypercerts lexicon. It deletes the signature type definitions, removes the optional signatures field from all record schemas that referenced them, updates documentation, deletes signature-related tests, and adjusts dependencies.

Changes

Cryptographic Signature Support Removal

Layer / File(s)	Summary
Delete signature lexicon type definitions `lexicons/app/certified/signature/defs.json`, `lexicons/app/certified/signature/proof.json`	Two lexicon files defining cryptographic signature structures (`app.certified.signature.defs` and `app.certified.signature.proof`) are deleted from the codebase.
Remove signatures field from hypercerts claim records `lexicons/org/hypercerts/claim/activity.json`, `lexicons/org/hypercerts/claim/contribution.json`, `lexicons/org/hypercerts/claim/contributorInformation.json`, `lexicons/org/hypercerts/claim/rights.json`	The optional `signatures` property is removed from all hypercerts claim-related record schemas.
Remove signatures field from hypercerts context and collection records `lexicons/org/hypercerts/context/acknowledgement.json`, `lexicons/org/hypercerts/context/attachment.json`, `lexicons/org/hypercerts/context/evaluation.json`, `lexicons/org/hypercerts/context/measurement.json`, `lexicons/org/hypercerts/collection.json`	The optional `signatures` property is removed from hypercerts context records and the collection record.
Remove signatures field from hypercerts funding record `lexicons/org/hypercerts/funding/receipt.json`	The optional `signatures` property is removed from the funding receipt record schema.
Remove signatures field from hypercerts workscope record `lexicons/org/hypercerts/workscope/tag.json`	The optional `signatures` property is removed from the workscope tag record schema.
Remove signatures field from certified lexicons `lexicons/app/certified/actor/organization.json`, `lexicons/app/certified/actor/profile.json`, `lexicons/app/certified/badge/definition.json`, `lexicons/app/certified/badge/award.json`, `lexicons/app/certified/badge/response.json`, `lexicons/app/certified/location.json`, `lexicons/app/certified/graph/follow.json`, `lexicons/app/certified/link/evm.json`	The optional `signatures` property is removed from all certified lexicon record schemas across actor, badge, location, graph, and link record types.
Remove signatures field from hyperboards records `lexicons/org/hyperboards/board.json`, `lexicons/org/hyperboards/displayProfile.json`	The optional `signatures` property is removed from hyperboards board and displayProfile record schemas.
Update auto-generated schema documentation `SCHEMAS.md`	All lexicon property tables are updated to remove `signatures` field rows; the entire `app.certified.signature.defs` documentation section is deleted.
Update guides and user-facing documentation `.agents/skills/building-with-hypercerts-lexicons/SKILL.md`, `README.md`, `ERD.puml`, `AGENTS.md`	Signature/attestation references are removed from SKILL.md (guide section and EVM Link row), README.md (lexicon map and signatures table), ERD.puml (`linkEvm` dataclass), and AGENTS.md (test guidance); a new "Cryptographic Signatures" documentation section is added to README.md.
Remove signature tests and update dependencies `tests/validate-signature-defs.test.ts`, `tests/validate-signature-defs-inline.test.ts`, `tests/validate-signature-proof.test.ts`, `tests/validate-signing-example.test.ts`, `package.json`, `.gitignore`	All signature validation test files are deleted; `@atproto/crypto` is removed from devDependencies; `viem` is downgraded from `^2.47.5` to `^2.46.3`; `.gitignore` entry for `tests/extracted/` is removed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

hypercerts-org/hypercerts-lexicon#170: This PR directly undoes all the cryptographic signature support additions from #170 by removing the signature lexicons and signatures fields from all affected record schemas.
hypercerts-org/hypercerts-lexicon#195: Both PRs touch the signature/attestation guide sections in .agents/skills/building-with-hypercerts-lexicons/SKILL.md, with this PR removing the content the earlier PR introduced.
hypercerts-org/hypercerts-lexicon#166: This PR removes signature support from lexicons/app/certified/link/evm.json, directly conflicting with the schema additions in #166.

Suggested labels

feature, breaking-change, documentation

Suggested reviewers

aspiers

Poem

🐰 Signatures fade like morning dew,
cryptographic dreams removed from view,
lexicons simplified once more,
attestations knocked upon the door.
Hippity-hop, the cleanup's done! 🥕

🚥 Pre-merge checks | ✅ 7

✅ Passed checks (7 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately describes the primary change: reverting a previous commit that added cryptographic signature support to all lexicons.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Lexicon Documentation Sync	✅ Passed	All lexicon JSON files, README.md, ERD.puml, and SCHEMAS.md are properly synchronized. Removed signature lexicons and signatures properties are completely cleaned up with no orphaned references.
Lexicons Styleguide Compliance	✅ Passed	All 43 lexicon files comply with ATProto styleguide: lowerCamelCase naming, proper metadata, no invalid characters. Signature lexicons correctly removed. One intentional deviation documented.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch revert-170-feat/signature-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Revert "NON-BREAKING: [HYPER-181] add cryptographic signature support…

897201b

… to all lexicons"

claude Bot reviewed May 21, 2026

View reviewed changes

aspiers approved these changes May 21, 2026

View reviewed changes

holkexyz approved these changes May 21, 2026

View reviewed changes

s-adamantine merged commit 9830196 into main May 21, 2026
6 checks passed

s-adamantine deleted the revert-170-feat/signature-support branch May 21, 2026 17:26

aspiers mentioned this pull request May 21, 2026

[HYPER-181] add cryptographic signature support to record lexicons (resubmission of #170) #219

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert "NON-BREAKING: [HYPER-181] add cryptographic signature support to all lexicons"#216

Revert "NON-BREAKING: [HYPER-181] add cryptographic signature support to all lexicons"#216
s-adamantine merged 1 commit into
mainfrom
revert-170-feat/signature-support

s-adamantine commented May 21, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

claude Bot left a comment

Uh oh!

changeset-bot Bot commented May 21, 2026

Uh oh!

coderabbitai Bot commented May 21, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

s-adamantine commented May 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

changeset-bot Bot commented May 21, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

s-adamantine commented May 21, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 21, 2026 •

edited

Loading