Skip to content

Commit 67a085e

Browse files
aspiersCopilot
andauthored
chore: apply suggestions from Copilot code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent db6f649 commit 67a085e

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

packages/sdk-core/src/services/hypercerts/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ export type StrongRef = ComAtprotoRepoStrongRef.Main;
137137
* };
138138
* ```
139139
*
140-
* @see {@link https://atproto.com/specs/record-key#record-key-type|AT Protocol Facets}
140+
* @see {@link https://atproto.com/specs/richtext#facets|AT Protocol Rich Text Facets}
141141
*/
142142
export type HypercertClaim = OrgHypercertsClaimActivity.Main;
143143

specs/lexicon-sync/v0.10.0-beta.4-v0.10.0-beta.11.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ implemented, validated, and reviewed before proceeding to the next.
7777
- [x] Tests pass (`pnpm test` - 102 tests in HypercertOperationsImpl)
7878
- [x] Types export correctly
7979

80-
**Status**: ✅ Complete
80+
**Status**: ⏳ In progress (documentation pending)
8181

8282
---
8383

@@ -171,12 +171,10 @@ implemented, validated, and reviewed before proceeding to the next.
171171

172172
**SDK Tasks**:
173173

174-
- [x] Import `AppBskyRichtextFacet` from `@atproto/api` in interfaces.ts
175-
- [x] Add `shortDescriptionFacets` and `descriptionFacets` fields to `CreateHypercertParams`
176-
- [x] Update `create()` method in `HypercertOperationsImpl` to handle facet fields
177-
- [x] Add comprehensive documentation to `HypercertClaim` type about facets
178-
- [x] Add usage examples showing how to create facets for mentions, links, and tags
179-
- [x] Verify facets are properly validated by lexicon validator
174+
- [x] Verify `CreateCollectionParams` supports a `location` field
175+
- [x] Update `createCollection` and `updateCollection` methods to handle the `location` property
176+
- [x] Add documentation and usage examples for the collection `location` property
177+
- [x] Add tests for collections with `location` references
180178
- [x] Build and test
181179
- [x] Create changeset (minor - new feature available)
182180

0 commit comments

Comments
 (0)