fix: preserve empty arrays in facet fields

[aspiers]

Change truthy checks to explicit !== undefined checks for shortDescriptionFacets and descriptionFacets to ensure empty arrays are preserved as valid values.

Fixes unresolved comment from PR #112 review thread #3700691486

Summary by CodeRabbit

• Bug Fixes
  • Fixed handling of description fields during record creation so explicitly provided falsy or null values for short description and description are now preserved instead of being ignored.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

---

Note

Ensures facet fields are written even when empty arrays are provided.

• In HypercertOperationsImpl.ts createHypercertRecord, changed checks to params.* !== undefined for shortDescriptionFacets and descriptionFacets, allowing empty arrays to be persisted instead of being skipped.

^{Written by Cursor Bugbot for commit e97a283. This will update automatically on new commits. Configure here.}

[changeset-bot]

⚠️ No Changeset found

Latest commit: e97a283

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Changed two truthiness guards in createHypercertRecord to explicit !== undefined checks so provided but falsy values (e.g., null, "") for shortDescriptionFacets and descriptionFacets are still assigned.

Changes

Cohort / File(s)	Summary
Guard condition refinement packages/sdk-core/src/repository/HypercertOperationsImpl.ts	Replaced truthy checks on params.shortDescriptionFacets and params.descriptionFacets with explicit !== undefined comparisons to preserve assignment of provided falsy values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I hopped through code with careful paws,
Found a check that gave me pause.
Now undefined and false are split,
Properly assigned — a tidy fit.
Hooray for clarity! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: preserve empty arrays in facet fields' accurately summarizes the main change: replacing truthy checks with explicit undefined comparisons to preserve empty arrays as valid values.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Updates hypercert record creation to preserve empty facet arrays by switching from truthy checks to explicit !== undefined checks.

Changes:

• Preserve shortDescriptionFacets when provided as an empty array by checking !== undefined.
• Preserve descriptionFacets when provided as an empty array by checking !== undefined.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.