Skip to content

lint: run prettier on packages/sdk-core/src/lib files#118

Merged
aspiers merged 1 commit into
developfrom
prettier-lib
Jan 26, 2026
Merged

lint: run prettier on packages/sdk-core/src/lib files#118
aspiers merged 1 commit into
developfrom
prettier-lib

Conversation

@aspiers
Copy link
Copy Markdown
Contributor

@aspiers aspiers commented Jan 26, 2026

Note

Updates code style and tooling while adding coverage for crypto utilities.

  • Format packages/sdk-core/src/lib/crypto.ts with Prettier (no functional changes)
  • Add tests for stableStringify behavior and sha256Hash validation errors in packages/sdk-core/tests/lib/crypto.test.ts
  • Update tooling: expand .prettierignore entries (logs/lockfiles/pnpm store) and remove **/lib from ignore list

Written by Cursor Bugbot for commit ca03f57. This will update automatically on new commits. Configure here.

Summary by CodeRabbit

  • Style

    • Applied code formatting and indentation adjustments to maintain consistency.
  • Chores

    • Updated Prettier configuration to include previously ignored directories.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 26, 2026 07:46
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 26, 2026

⚠️ No Changeset found

Latest commit: ca03f57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 26, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The PR removes the **/lib ignore pattern from .prettierignore, enabling Prettier to format library files. Two crypto-related files in the lib directory subsequently receive formatting adjustments including spacing, indentation, and comment alignment, with no functional or logic changes.

Changes

Cohort / File(s) Summary
Configuration
.prettierignore
Removed **/lib ignore pattern to allow Prettier to format lib directory files
Formatting Updates
packages/sdk-core/src/lib/crypto.ts, packages/sdk-core/tests/lib/crypto.test.ts
Spacing, indentation, and comment alignment adjustments; no logic or control flow changes

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • Kzoeps

Poem

🐰 A fluffy formatter hops along,
Fixing spaces, making code strong,
Lib files now dance in Prettier's grace,
No logic changed, just formatting pace!

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aspiers aspiers enabled auto-merge January 26, 2026 07:47
@aspiers aspiers merged commit 31c9342 into develop Jan 26, 2026
8 of 9 checks passed
@aspiers aspiers deleted the prettier-lib branch January 26, 2026 07:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Prettier scope so lib directories are no longer globally ignored, and applies Prettier formatting to the SDK core crypto utilities (and their tests).

Changes:

  • Removed **/lib from .prettierignore so Prettier runs on src/lib content.
  • Applied Prettier formatting to packages/sdk-core/src/lib/crypto.ts.
  • Applied Prettier formatting to packages/sdk-core/tests/lib/crypto.test.ts.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/sdk-core/src/lib/crypto.ts Prettier-only formatting of crypto helpers (stableStringify, sha256Hash).
packages/sdk-core/tests/lib/crypto.test.ts Prettier-only formatting of crypto unit tests.
.prettierignore Stops ignoring all lib directories so src/lib files are included in formatting checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants