Added symlink + mkdir/symlink test

Author: andrewosh

lib/drives/index.js

@@ -444,14 +444,19 @@ class DriveManager extends EventEmitter {
       mkdir: async (call) => {
         const id = call.request.getId()
         const path = call.request.getPath()
-        const mode = call.request.getMode()
+        const opts = fromStat(call.request.getOpts())
 
         if (!id) throw new Error('A mkdir request must specify a session ID.')
         if (!path) throw new Error('A mkdir request must specify a directory path.')
         const drive = this.driveForSession(id)
 
+        const mkdirOpts = {}
+        if (opts.uid) mkdirOpts.uid = opts.uid
+        if (opts.gid) mkdirOpts.gid = opts.gid
+        if (opts.mode) mkdirOpts.mode = opts.mode
+
         return new Promise((resolve, reject) => {
-          drive.mkdir(path, mode, err => {
+          drive.mkdir(path, mkdirOpts, err => {
             if (err) return reject(err)
 
             const rsp = new rpc.drive.messages.MkdirResponse()
@@ -569,6 +574,26 @@ class DriveManager extends EventEmitter {
         }
       },
 
+      symlink: async (call) => {
+        const id = call.request.getId()
+        const target = call.request.getTarget()
+        const linkname = call.request.getLinkname()
+
+        if (!id) throw new Error('A symlink request must specify a session ID.')
+        if (!target) throw new Error('A symlink request must specify a target.')
+        if (!linkname) throw new Error('A symlink request must specify a linkname.')
+        const drive = this.driveForSession(id)
+
+        return new Promise((resolve, reject) => {
+          drive.symlink(target, linkname, err => {
+            if (err) return reject(err)
+
+            const rsp = new rpc.drive.messages.SymlinkResponse()
+            return resolve(rsp)
+          })
+        })
+      },
+
       close: async (call) => {
         const id = call.request.getId()
 

test/hyperdrive.js

@@ -294,6 +294,32 @@ test.skip('watch cleans up after unexpected close', async t => {
   t.end()
 })
 
+test('can create a symlink to directories', async t => {
+  const { client, cleanup } = await createOne()
+
+  try {
+    const drive = await client.drive.get()
+    await drive.mkdir('hello', { uid: 999 })
+    await drive.writeFile('hello/world', 'content')
+    await drive.symlink('hello', 'other_hello')
+    await drive.symlink('hello/world', 'other_world')
+
+    const contents = await drive.readFile('other_world')
+    t.same(contents, Buffer.from('content'))
+
+    const files = await drive.readdir('other_hello')
+    t.same(files.length, 1)
+    t.same(files[0], 'world')
+
+    await drive.close()
+  } catch (err) {
+    t.fail(err)
+  }
+
+  await cleanup()
+  t.end()
+})
+
 // TODO: Figure out why the grpc server is not terminating.
 test.onFinish(() => {
   setTimeout(() => {