Summary
On the Client Sessions page, clicking a session card opens the side panel and updates the URL with sid, sfrom, and sto query params. However, clicking Share Session immediately after copies the previous URL (without those params). Reloading the page and clicking Share Session again produces the correct URL.
Steps to reproduce
- Go to the
/sessions page (e.g. /sessions?sessionSource=<SOURCE_ID>&from=<FROM>&to=<TO>&where=&whereLanguage=lucene).
- Click any session card — the URL bar updates to include
&sid=<SID>&sfrom=<SFROM>&sto=<STO>.
- Click Share Session.
- Paste the clipboard contents.
Expected
/sessions?sessionSource=<SOURCE_ID>&from=<FROM>&to=<TO>&where=&whereLanguage=lucene&sid=<SID>&sfrom=<SFROM>&sto=<STO>
Actual
/sessions?sessionSource=<SOURCE_ID>&from=<FROM>&to=<TO>&where=&whereLanguage=lucene
After a page reload, step 3 produces the expected URL.
Root cause
In packages/app/src/SessionSidePanel.tsx (around line 128):
<CopyToClipboard text={window.location.href} ...>
setSelectedSession in SessionsPage.tsx:322 calls nuqs' setSelectedSessionQuery, which updates the React state synchronously but flushes window.history asynchronously (batched via startTransition + throttleMs).SessionSidePanel renders immediately when selectedSession != null, so window.location.href is read before nuqs has flushed sid/sfrom/sto into the URL.CopyToClipboard captures that stale value into its text prop. The panel does not re-render after the URL flush, so the stale value persists on click.- On reload, the URL already contains
sid/sfrom/sto, so the first render captures the correct URL.
Proposed fix
Either:
- Read URL at click time using
copyTextToClipboard from packages/app/src/utils/clipboard.ts inside an onClick handler — by the time the user clicks Share, nuqs has flushed.
- Build the URL from props (
sessionId, dateRange) with useMemo — deterministic, no dependency on URL flush timing.
Option 1 is preferred — simpler, reuses existing clipboard util (which also handles non-HTTPS fallback), and is future-proof against new params.
Affected file
packages/app/src/SessionSidePanel.tsx:128-145
Summary
On the Client Sessions page, clicking a session card opens the side panel and updates the URL with
sid,sfrom, andstoquery params. However, clicking Share Session immediately after copies the previous URL (without those params). Reloading the page and clicking Share Session again produces the correct URL.Steps to reproduce
/sessionspage (e.g./sessions?sessionSource=<SOURCE_ID>&from=<FROM>&to=<TO>&where=&whereLanguage=lucene).&sid=<SID>&sfrom=<SFROM>&sto=<STO>.Expected
Actual
After a page reload, step 3 produces the expected URL.
Root cause
In
packages/app/src/SessionSidePanel.tsx(around line 128):setSelectedSessioninSessionsPage.tsx:322callsnuqs'setSelectedSessionQuery, which updates the React state synchronously but flusheswindow.historyasynchronously (batched viastartTransition+throttleMs).SessionSidePanelrenders immediately whenselectedSession != null, sowindow.location.hrefis read beforenuqshas flushedsid/sfrom/stointo the URL.CopyToClipboardcaptures that stale value into itstextprop. The panel does not re-render after the URL flush, so the stale value persists on click.sid/sfrom/sto, so the first render captures the correct URL.Proposed fix
Either:
copyTextToClipboardfrompackages/app/src/utils/clipboard.tsinside anonClickhandler — by the time the user clicks Share,nuqshas flushed.sessionId,dateRange) withuseMemo— deterministic, no dependency on URL flush timing.Option 1 is preferred — simpler, reuses existing clipboard util (which also handles non-HTTPS fallback), and is future-proof against new params.
Affected file
packages/app/src/SessionSidePanel.tsx:128-145