Improve error reporting SSL & port binding#2017
Conversation
|
Hello @Lord-Grey 👋 I'm the Hyperion Project Bot and I want to thank you for To help you and other users test your pull requests faster, 🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/26336534728 Of course, if you make changes to your PR, I will create a new link. Best regards, |
There was a problem hiding this comment.
Pull request overview
This PR improves runtime diagnostics around network startup failures: (1) adding clearer SSL runtime failure logging for REST-based LED devices and (2) enhancing port-binding error reporting (notably for Windows scenarios where the Web UI fails to start when a system proxy is enabled).
Changes:
ProviderRestApi: validate CA certificate parsing, preserve existing CA list, and log explicit errors when Qt SSL is compiled in but runtime SSL libraries fail to load (plus a message forQT_NO_SSLbuilds).NetUtils::portAvailable: log socket binding failure details (error code + string) and add special handling forSocketAccessError.- Update
CHANGELOG.mdwith entries for the Windows/UI error-detail improvement and the ProviderRestAPI SSL error logging.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| libsrc/leddevice/dev_net/ProviderRestApi.cpp | Adds certificate validity checks and clearer SSL-runtime failure diagnostics when SSL support can’t be used. |
| include/utils/NetUtils.h | Enhances port binding failure logging and adjusts behavior on access-denied binding errors. |
| CHANGELOG.md | Documents the Windows/UI error-detail improvement and the ProviderRestAPI SSL error logging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hey @Lord-Grey I created a new link to your workflow artifacts: |
|
Hey @Lord-Grey I created a new link to your workflow artifacts: |
|
Hey @Lord-Grey I created a new link to your workflow artifacts: |
|
Hey @Lord-Grey I created a new link to your workflow artifacts: |
|
Hey @Lord-Grey I created a new link to your workflow artifacts: |
|
Hey @Lord-Grey I created a new link to your workflow artifacts: |
Summary
🔧 Changed
Technical
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
Fixes: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: