Skip to content

Improve error reporting SSL & port binding#2017

Merged
Lord-Grey merged 10 commits into
hyperion-project:masterfrom
Lord-Grey:ssl
May 25, 2026
Merged

Improve error reporting SSL & port binding#2017
Lord-Grey merged 10 commits into
hyperion-project:masterfrom
Lord-Grey:ssl

Conversation

@Lord-Grey

@Lord-Grey Lord-Grey commented May 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

🔧 Changed


Technical

  • ProviderRestAPI - Add error when failing to load QT SSL

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@Lord-Grey Lord-Grey self-assigned this May 23, 2026
Copilot AI review requested due to automatic review settings May 23, 2026 15:27
@Lord-Grey Lord-Grey moved this to In Progress in Core May 23, 2026
@Lord-Grey Lord-Grey moved this from Backlog to In Progress in Output Devices May 23, 2026
@hyperion-project

Copy link
Copy Markdown

Hello @Lord-Grey 👋

I'm the Hyperion Project Bot and I want to thank you for
contributing to Hyperion with your pull requests!

To help you and other users test your pull requests faster,
I'll create a link for you to your workflow artifacts.

🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/26336534728

Of course, if you make changes to your PR, I will create a new link.

Best regards,
Hyperion Project

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves runtime diagnostics around network startup failures: (1) adding clearer SSL runtime failure logging for REST-based LED devices and (2) enhancing port-binding error reporting (notably for Windows scenarios where the Web UI fails to start when a system proxy is enabled).

Changes:

  • ProviderRestApi: validate CA certificate parsing, preserve existing CA list, and log explicit errors when Qt SSL is compiled in but runtime SSL libraries fail to load (plus a message for QT_NO_SSL builds).
  • NetUtils::portAvailable: log socket binding failure details (error code + string) and add special handling for SocketAccessError.
  • Update CHANGELOG.md with entries for the Windows/UI error-detail improvement and the ProviderRestAPI SSL error logging.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
libsrc/leddevice/dev_net/ProviderRestApi.cpp Adds certificate validity checks and clearer SSL-runtime failure diagnostics when SSL support can’t be used.
include/utils/NetUtils.h Enhances port binding failure logging and adjusts behavior on access-denied binding errors.
CHANGELOG.md Documents the Windows/UI error-detail improvement and the ProviderRestAPI SSL error logging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/utils/NetUtils.h Outdated
Comment thread include/utils/NetUtils.h Outdated
Comment thread include/utils/NetUtils.h Outdated
Comment thread include/utils/NetUtils.h Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
@hyperion-project

Copy link
Copy Markdown

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/26336831223

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread include/utils/NetUtils.h
Comment thread CHANGELOG.md Outdated
@hyperion-project

Copy link
Copy Markdown

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/26337180548

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Comment thread libsrc/leddevice/dev_net/ProviderRestApi.cpp Outdated
Comment thread libsrc/leddevice/dev_net/ProviderRestApi.cpp Outdated
Comment thread CHANGELOG.md
Comment thread CHANGELOG.md
@hyperion-project

Copy link
Copy Markdown

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/26338597303

@hyperion-project

Copy link
Copy Markdown

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/26391785263

@hyperion-project

Copy link
Copy Markdown

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/26392510576

@hyperion-project

Copy link
Copy Markdown

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/26410952576

@Lord-Grey Lord-Grey merged commit f2e8fe7 into hyperion-project:master May 25, 2026
22 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Output Devices May 25, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Core May 25, 2026
@Lord-Grey Lord-Grey deleted the ssl branch May 25, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants