chore: use standard library api (#263)

tottoto · web-flow · commit ffa53913bef0 · 2026-02-02T09:01:11.000-05:00
diff --git a/Cargo.toml b/Cargo.toml
@@ -21,7 +21,6 @@ rustdoc-args = ["--cfg", "docsrs"]
 base64 = { version = "0.22", optional = true }
 bytes = "1.7.1"
 futures-channel = { version = "0.3", optional = true }
-futures-core = { version = "0.3" }
 futures-util = { version = "0.3.16", default-features = false, optional = true }
 http = "1.0"
 http-body = "1.0.0"
diff --git a/src/client/legacy/client.rs b/src/client/legacy/client.rs
@@ -6,7 +6,7 @@
 
 use std::error::Error as StdError;
 use std::fmt;
-use std::future::Future;
+use std::future::{poll_fn, Future};
 use std::pin::Pin;
 use std::task::{self, Poll};
 use std::time::Duration;
@@ -25,7 +25,6 @@ use super::connect::HttpConnector;
 use super::connect::{Alpn, Connect, Connected, Connection};
 use super::pool::{self, Ver};
 
-use crate::common::future::poll_fn;
 use crate::common::{lazy as hyper_lazy, timer, Exec, Lazy, SyncWrapper};
 
 type BoxSendFuture = Pin<Box<dyn Future<Output = ()> + Send>>;
@@ -337,7 +336,7 @@ where
                         e!(SendRequest, err.into_error())
                             .with_connect_info(pooled.conn_info.clone()),
                     ))
-                }
+                };
             }
         };
 
diff --git a/src/client/legacy/connect/dns.rs b/src/client/legacy/connect/dns.rs
@@ -291,7 +291,7 @@ pub(super) async fn resolve<R>(resolver: &mut R, name: Name) -> Result<R::Addrs,
 where
     R: Resolve,
 {
-    crate::common::future::poll_fn(|cx| resolver.poll_ready(cx)).await?;
+    std::future::poll_fn(|cx| resolver.poll_ready(cx)).await?;
     resolver.resolve(name).await
 }
 
diff --git a/src/client/legacy/connect/http.rs b/src/client/legacy/connect/http.rs
@@ -6,10 +6,9 @@ use std::marker::PhantomData;
 use std::net::{IpAddr, Ipv4Addr, Ipv6Addr, SocketAddr};
 use std::pin::Pin;
 use std::sync::Arc;
-use std::task::{self, Poll};
+use std::task::{self, ready, Poll};
 use std::time::Duration;
 
-use futures_core::ready;
 use futures_util::future::Either;
 use http::uri::{Scheme, Uri};
 use pin_project_lite::pin_project;
diff --git a/src/client/legacy/connect/proxy/tunnel.rs b/src/client/legacy/connect/proxy/tunnel.rs
@@ -2,9 +2,8 @@ use std::error::Error as StdError;
 use std::future::Future;
 use std::marker::{PhantomData, Unpin};
 use std::pin::Pin;
-use std::task::{self, Poll};
+use std::task::{self, ready, Poll};
 
-use futures_core::ready;
 use http::{HeaderMap, HeaderValue, Uri};
 use hyper::rt::{Read, Write};
 use pin_project_lite::pin_project;
diff --git a/src/client/legacy/pool.rs b/src/client/legacy/pool.rs
@@ -9,12 +9,11 @@ use std::hash::Hash;
 use std::ops::{Deref, DerefMut};
 use std::pin::Pin;
 use std::sync::{Arc, Mutex, Weak};
-use std::task::{self, Poll};
+use std::task::{self, ready, Poll};
 
 use std::time::{Duration, Instant};
 
 use futures_channel::oneshot;
-use futures_core::ready;
 use tracing::{debug, trace};
 
 use hyper::rt::Timer as _;
diff --git a/src/client/pool/cache.rs b/src/client/pool/cache.rs
@@ -22,9 +22,8 @@ mod internal {
     use std::future::Future;
     use std::pin::Pin;
     use std::sync::{Arc, Mutex, Weak};
-    use std::task::{self, Poll};
+    use std::task::{self, ready, Poll};
 
-    use futures_core::ready;
     use futures_util::future;
     use tokio::sync::oneshot;
     use tower_service::Service;
@@ -451,7 +450,7 @@ mod tests {
         let mut cache = super::builder().build(mock);
         handle.allow(1);
 
-        crate::common::future::poll_fn(|cx| cache.poll_ready(cx))
+        std::future::poll_fn(|cx| cache.poll_ready(cx))
             .await
             .unwrap();
 
@@ -473,7 +472,7 @@ mod tests {
         // only 1 connection should ever be made
         handle.allow(1);
 
-        crate::common::future::poll_fn(|cx| cache.poll_ready(cx))
+        std::future::poll_fn(|cx| cache.poll_ready(cx))
             .await
             .unwrap();
         let f = cache.call(1);
@@ -485,7 +484,7 @@ mod tests {
         .expect("call");
         drop(cached);
 
-        crate::common::future::poll_fn(|cx| cache.poll_ready(cx))
+        std::future::poll_fn(|cx| cache.poll_ready(cx))
             .await
             .unwrap();
         let f = cache.call(1);
diff --git a/src/client/pool/negotiate.rs b/src/client/pool/negotiate.rs
@@ -49,9 +49,8 @@ mod internal {
     use std::future::Future;
     use std::pin::Pin;
     use std::sync::{Arc, Mutex};
-    use std::task::{self, Poll};
+    use std::task::{self, ready, Poll};
 
-    use futures_core::ready;
     use pin_project_lite::pin_project;
     use tower_layer::Layer;
     use tower_service::Service;
@@ -580,7 +579,7 @@ mod tests {
             .upgrade(layer_fn(|s| s))
             .build();
 
-        crate::common::future::poll_fn(|cx| negotiate.poll_ready(cx))
+        std::future::poll_fn(|cx| negotiate.poll_ready(cx))
             .await
             .unwrap();
 
@@ -605,7 +604,7 @@ mod tests {
             .upgrade(layer_fn(|s| s))
             .build();
 
-        crate::common::future::poll_fn(|cx| negotiate.poll_ready(cx))
+        std::future::poll_fn(|cx| negotiate.poll_ready(cx))
             .await
             .unwrap();
 
diff --git a/src/client/pool/singleton.rs b/src/client/pool/singleton.rs
@@ -152,9 +152,8 @@ mod internal {
     use std::future::Future;
     use std::pin::Pin;
     use std::sync::{Mutex, Weak};
-    use std::task::{self, Poll};
+    use std::task::{self, ready, Poll};
 
-    use futures_core::ready;
     use pin_project_lite::pin_project;
     use tokio::sync::oneshot;
     use tower_service::Service;
@@ -351,7 +350,7 @@ mod tests {
         let mut singleton = Singleton::new(mock_svc);
 
         handle.allow(1);
-        crate::common::future::poll_fn(|cx| singleton.poll_ready(cx))
+        std::future::poll_fn(|cx| singleton.poll_ready(cx))
             .await
             .unwrap();
         // First call: should go into Driving
@@ -374,7 +373,7 @@ mod tests {
         let mut singleton = Singleton::new(mock_svc);
 
         handle.allow(1);
-        crate::common::future::poll_fn(|cx| singleton.poll_ready(cx))
+        std::future::poll_fn(|cx| singleton.poll_ready(cx))
             .await
             .unwrap();
         // Drive first call to completion
@@ -396,7 +395,7 @@ mod tests {
 
         // Allow the singleton to be made
         outer_handle.allow(2);
-        crate::common::future::poll_fn(|cx| singleton.poll_ready(cx))
+        std::future::poll_fn(|cx| singleton.poll_ready(cx))
             .await
             .unwrap();
 
@@ -417,15 +416,15 @@ mod tests {
         ));
 
         // Drive poll_ready on cached service
-        let err = crate::common::future::poll_fn(|cx| cached.poll_ready(cx))
+        let err = std::future::poll_fn(|cx| cached.poll_ready(cx))
             .await
             .err()
             .expect("expected poll_ready error");
         assert_eq!(err.to_string(), "cached poll_ready failed");
 
         // After error, the singleton should be cleared, so a new call drives outer again
         outer_handle.allow(1);
-        crate::common::future::poll_fn(|cx| singleton.poll_ready(cx))
+        std::future::poll_fn(|cx| singleton.poll_ready(cx))
             .await
             .unwrap();
         let fut2 = singleton.call(());
@@ -436,7 +435,7 @@ mod tests {
 
         // The new cached service should still work
         inner_handle2.allow(1);
-        crate::common::future::poll_fn(|cx| cached2.poll_ready(cx))
+        std::future::poll_fn(|cx| cached2.poll_ready(cx))
             .await
             .expect("expected poll_ready");
         let cfut2 = cached2.call(());
@@ -450,7 +449,7 @@ mod tests {
         let (mock_svc, mut handle) = tower_test::mock::pair::<(), &'static str>();
         let mut singleton = Singleton::new(mock_svc);
 
-        crate::common::future::poll_fn(|cx| singleton.poll_ready(cx))
+        std::future::poll_fn(|cx| singleton.poll_ready(cx))
             .await
             .unwrap();
         let fut1 = singleton.call(());
@@ -469,14 +468,14 @@ mod tests {
         let (mock_svc, mut handle) = tower_test::mock::pair::<(), &'static str>();
         let mut singleton = Singleton::new(mock_svc);
 
-        crate::common::future::poll_fn(|cx| singleton.poll_ready(cx))
+        std::future::poll_fn(|cx| singleton.poll_ready(cx))
             .await
             .unwrap();
         let mut fut1 = singleton.call(());
         let fut2 = singleton.call(());
 
         // poll driver just once, and then drop
-        crate::common::future::poll_fn(move |cx| {
+        std::future::poll_fn(move |cx| {
             let _ = Pin::new(&mut fut1).poll(cx);
             Poll::Ready(())
         })
diff --git a/src/common/future.rs b/src/common/future.rs
diff --git a/src/common/mod.rs b/src/common/mod.rs
@@ -17,5 +17,3 @@ pub(crate) use exec::Exec;
 pub(crate) use lazy::{lazy, Started as Lazy};
 #[cfg(feature = "client-legacy")]
 pub(crate) use sync::SyncWrapper;
-
-pub(crate) mod future;
diff --git a/src/rt/io.rs b/src/rt/io.rs
@@ -1,11 +1,10 @@
 use std::marker::Unpin;
 use std::pin::Pin;
-use std::task::Poll;
+use std::task::{ready, Poll};
 
-use futures_core::ready;
 use hyper::rt::{Read, ReadBuf, Write};
 
-use crate::common::future::poll_fn;
+use std::future::poll_fn;
 
 pub(crate) async fn read<T>(io: &mut T, buf: &mut [u8]) -> Result<usize, std::io::Error>
 where
diff --git a/src/server/conn/auto/mod.rs b/src/server/conn/auto/mod.rs
@@ -7,11 +7,10 @@ use std::future::Future;
 use std::marker::PhantomPinned;
 use std::mem::MaybeUninit;
 use std::pin::Pin;
-use std::task::{Context, Poll};
+use std::task::{ready, Context, Poll};
 use std::{error::Error as StdError, io, time::Duration};
 
 use bytes::Bytes;
-use futures_core::ready;
 use http::{Request, Response};
 use http_body::Body;
 use hyper::{
diff --git a/src/service/oneshot.rs b/src/service/oneshot.rs
@@ -1,8 +1,7 @@
-use futures_core::ready;
 use pin_project_lite::pin_project;
 use std::future::Future;
 use std::pin::Pin;
-use std::task::{Context, Poll};
+use std::task::{ready, Context, Poll};
 use tower_service::Service;
 
 // Vendored from tower::util to reduce dependencies, the code is small enough.
diff --git a/tests/legacy_client.rs b/tests/legacy_client.rs
@@ -132,7 +132,7 @@ async fn drop_client_closes_idle_connections() {
     res.unwrap();
 
     // not closed yet, just idle
-    future::poll_fn(|ctx| {
+    std::future::poll_fn(|ctx| {
         assert!(Pin::new(&mut closes).poll_next(ctx).is_pending());
         Poll::Ready(())
     })
@@ -561,7 +561,7 @@ async fn client_keep_alive_when_response_before_request_body_ends() {
     });
 
     future::join(res, rx2).await.0.unwrap();
-    future::poll_fn(|ctx| {
+    std::future::poll_fn(|ctx| {
         assert!(Pin::new(&mut closes).poll_next(ctx).is_pending());
         Poll::Ready(())
     })
@@ -1255,7 +1255,7 @@ impl tower_service::Service<hyper::Uri> for MockConnector {
     type Error = std::io::Error;
     type Future = std::pin::Pin<
         Box<
-            dyn futures_util::Future<Output = std::result::Result<Self::Response, Self::Error>>
+            dyn std::future::Future<Output = std::result::Result<Self::Response, Self::Error>>
                 + Send,
         >,
     >;
diff --git a/tests/test_utils/mod.rs b/tests/test_utils/mod.rs
@@ -1,10 +1,10 @@
+use std::future::Future;
 use std::pin::Pin;
 use std::sync::atomic::{AtomicUsize, Ordering};
 use std::sync::Arc;
+use std::task::{Context, Poll};
 
 use futures_channel::mpsc;
-use futures_util::task::{Context, Poll};
-use futures_util::Future;
 use futures_util::TryFutureExt;
 use hyper::Uri;
 use tokio::io::{self, AsyncRead, AsyncWrite, ReadBuf};

Original file line number	Diff line number	Diff line change
`@@ -291,7 +291,7 @@ pub(super) async fn resolve<R>(resolver: &mut R, name: Name) -> Result<R::Addrs,`
`291`	`291`	`where`
`292`	`292`	`R: Resolve,`
`293`	`293`	`{`
`294`		`- crate::common::future::poll_fn(\|cx\| resolver.poll_ready(cx)).await?;`
	`294`	`+ std::future::poll_fn(\|cx\| resolver.poll_ready(cx)).await?;`
`295`	`295`	`resolver.resolve(name).await`
`296`	`296`	`}`
`297`	`297`