refactor: modernize Makefile and align with current Docker workflow#775
Closed
Anuj192006 wants to merge 1 commit into
Closed
refactor: modernize Makefile and align with current Docker workflow#775Anuj192006 wants to merge 1 commit into
Anuj192006 wants to merge 1 commit into
Conversation
- Fix broken Dockerfile paths in Makefile - Modernize Docker Compose commands (v2) - Unified dev/prod deployment flow - Added ARCH detection for Mac compatibility - Removed obsolete environment variables Fixes hyperledger-cello#767 Signed-off-by: Anuj192006 <anuju712@gmail.com>
ryjones
force-pushed
the
refactor/modernize-makefile
branch
from
f158698 to
e035ba1
Compare
Author
|
Thanks for the update. I’ll review the latest changes made to the branch. I also noticed the workflows are awaiting maintainer approval, so I’ll wait for them to run. Please let me know if anything else is needed from my side. |
Contributor
|
Need to rebase first. |
Author
|
I rebased the branch onto the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites the main Makefile to address issue #767, bringing it in line with the project's current repository structure and modern Docker Compose (v2) practices.
Key Changes:
src/subdirectories, replacing dead references to thebuild_image/folder.start,stop, andcleantargets to use a consistent Compose file selection based on aMODEtoggle (dev/prod).arm64(Mac M1/M2) compatibility by mapping toamd64for builds.IMG_TAG) for local builds.Validation:
make helpoutput for correct target categorization.docker-compose.dev.yamlandMakefile.Fixes #767