Address PR feedback: improve navigation components

Signed-off-by: Andrew Sawers <ajmsawers@gmail.com>

Author: ajmsawers

src/components/Navigation/ActivityNav.tsx

@@ -1,3 +1,19 @@
+// Copyright © 2022 Kaleido, Inc.
+//
+// SPDX-License-Identifier: Apache-2.0
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
 import { InsertChartOutlined } from '@mui/icons-material';
 import React, { useContext } from 'react';
 import { useTranslation } from 'react-i18next';

src/components/Navigation/NavItem.tsx

@@ -29,8 +29,6 @@ interface Props {
   icon?: JSX.Element;
   rightIcon?: JSX.Element;
   isRoot?: boolean;
-
-  // NEW:
   to?: string; // internal route (React Router)
   href?: string; // external link
   action?: () => void; // fallback click handler (legacy)

src/components/Navigation/Navigation.tsx

@@ -4,7 +4,7 @@ import MenuBookIcon from '@mui/icons-material/MenuBook';
 import { Drawer, List } from '@mui/material';
 import { default as React, useContext } from 'react';
 import { useTranslation } from 'react-i18next';
-import { useLocation, useNavigate } from 'react-router-dom';
+import { useLocation } from 'react-router-dom';
 import { ApplicationContext } from '../../contexts/ApplicationContext';
 import { FF_NAV_PATHS } from '../../interfaces';
 import { MenuLogo } from '../MenuLogo';
@@ -23,7 +23,6 @@ export const Navigation: React.FC = () => {
   const { selectedNamespace } = useContext(ApplicationContext);
   const { t } = useTranslation();
   const { pathname } = useLocation();
-  const navigate = useNavigate();
 
   const makeDrawerContents = (
     <>

src/interfaces/navigation.ts

@@ -21,11 +21,12 @@ export interface INavItem {
   itemIsActive: boolean;
   icon?: JSX.Element;
 
-  // NEW optional props for link-style behavior
+  // Preferred props for link/navigation behavior
   to?: string; // internal React Router path
   href?: string; // external URL
 
-  // fallback for legacy click handlers
+  // DEPRECATED: legacy click handler (prefer `to` or `href`)
+  /** @deprecated use `to` or `href` instead */
   action?: () => void;
 }