feat(cli): add support for dynamic configuration overrides in init command #444#732
feat(cli): add support for dynamic configuration overrides in init command #444#732HarK-github wants to merge 18 commits into
Conversation
Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 7.5.0 to 7.5.5. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md) - [Commits](protobufjs/protobuf.js@protobufjs-v7.5.0...protobufjs-v7.5.5) --- updated-dependencies: - dependency-name: protobufjs dependency-version: 7.5.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…mmand Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
|
I ran it locally, but it doesn’t work as expected. When running: |
|
@OsamaRab3 I have made some changes. Try using set flag . ex :/fablo.sh init --set global.fabricVersion=2.5.0 --set global.tls=false |
Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
|
@OsamaRab3 did it work? |
|
@OsamaRab3 can you have a look please |
Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
| if (/^-?(0|[1-9]\d*)(\.\d+)?$/.test(trimmed) && trimmed !== "") { | ||
| return Number(trimmed); | ||
| } |
There was a problem hiding this comment.
&& trimmed !== "" redundant regex already rejects empty string
Could you update the documentation with a few examples showing how to use --set? |
Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
|
Tick the box to add this pull request to the merge queue (same as
|
Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
Add Support for Dynamic Configuration Overrides in
fablo initThis PR introduces the ability to override any property in the default
fablo-config.jsondirectly from the CLI duringfablo initusing the--setflag.1. New
--setFlag--set key=valuesyntax--setflags in a single commandfablo init --set global.fabricVersion=2.5.0 --set global.tls=false2. Smart Type Casting
The parser automatically detects and converts values to appropriate types:
true/false→ boolean type5,3.14→ number type{"key":"value"},[1,2,3]→ object/array type3. Nested Path Support
global.monitoring.loglevel=debugorgs[0].peer.db=CouchDb4. Backward Compatibility
node,dev,ccaas,gateway,restpositional arguments5. E2E Test Coverage
Added comprehensive test coverage for:
Usage Examples: