fix: correct isV3 ternary in chaincode-functions and add clarifying comments#743
Open
Dimensionexpert wants to merge 1 commit into
Open
Conversation
Dimensionexpert
force-pushed
the
fix/chaincode-functions-v3-template
branch
from
b523c53 to
0607647
Compare
…omments Both branches of the ternary in _copyUtilityScripts() returned 'v2', so Fabric v3 users silently got the v2 chaincode-functions.sh template. Fixed to use capabilities.isV3 like the other scripts in the same method. Added cross-reference comments above _copyUtilityScripts in both setup-docker and setup-k8s clarifying that the version suffixes mean different things in each context (HLF version vs install flow style). Fixes hyperledger-labs#702 Signed-off-by: dimensionexpert <dimensionexpert2725@gmail.com>
Dimensionexpert
force-pushed
the
fix/chaincode-functions-v3-template
branch
from
0607647 to
6ab99eb
Compare
Dimensionexpert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both branches of the ternary in _copyUtilityScripts() returned 'v2',
so Fabric v3 users silently got the v2 chaincode-functions.sh template.
Fixed to use capabilities.isV3 like the other scripts in the same method.
Added cross-reference comments above _copyUtilityScripts in both
setup-docker and setup-k8s clarifying that the version suffixes mean
different things in each context (HLF version vs install flow style).
Fixes #702