Skip to content

Fix: Correct consensus typo and Raft support error message #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ujjwal-Gowda wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Fix: Correct consensus typo and Raft support error message #761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/commands/validate/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ export default class Validate extends Command {
if (orderer.instances > 1) {
const objectToEmit = {
category: validationCategories.ORDERER,
message: `Orderer consesus type is set to 'solo', but number of instances is ${orderer.instances}. Only 1 instance will be created.`,
message: `Orderer consensus type is set to 'solo', but number of instances is ${orderer.instances}. Only 1 instance will be created.`,
};
this.emit(validationErrorType.WARN, objectToEmit);
}
Expand All @@ -314,15 +314,15 @@ export default class Validate extends Command {
if (orderer.instances === 1) {
const objectToEmit = {
category: validationCategories.ORDERER,
message: `Orderer consesus type is set to '${orderer.type}', but number of instances is 1. Network won't be fault tolerant! Consider higher value.`,
message: `Orderer consensus type is set to '${orderer.type}', but number of instances is 1. Network won't be fault tolerant! Consider higher value.`,
};
this.emit(validationErrorType.WARN, objectToEmit);
}

if (!config.versionsSupportingRaft(global.fabricVersion)) {
const objectToEmit = {
category: validationCategories.ORDERER,
message: `Fabric's ${global.fabricVersion} does not support Raft consensus type. Supporting versions are: ${config.versionsSupportingRaft}`,
message: `Fabric's ${global.fabricVersion} does not support Raft consensus type. Supporting versions are: 1.4.3 or higher.`,
};
this.emit(validationErrorType.ERROR, objectToEmit);
}
Expand Down
Loading