Removes the unused hyperledgerExplorerVersion: "1.1.8" setting from src/setup-k8s/index.ts.#771
Open
Efeguclu1 wants to merge 2 commits into
Open
Conversation
umegbewe
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran the generator: the produced K8s .env doesn't contain the explorer version at all (whereas the Docker output does, proving the test would catch it if it were used), and after removing the line the K8s
snapshot test passes with byte-identical output. Since this value's only possible effect is to be rendered into a generated file, and it reaches none, removing it is safe and changes nothing.