fix: remove unused hyperledgerExplorerVersion from k8s setup#778
Open
Efeguclu1 wants to merge 1 commit into
Open
fix: remove unused hyperledgerExplorerVersion from k8s setup#778Efeguclu1 wants to merge 1 commit into
Efeguclu1 wants to merge 1 commit into
Conversation
Signed-off-by: Efeguclu1 <efeguclu3435@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove unused hyperledgerExplorerVersion from k8s setup
Fixes #708
Problem
src/setup-k8s/index.tshardcodedhyperledgerExplorerVersion: "1.1.8", butthis value is never rendered into any generated K8s file. It only existed as
dead configuration and caused a confusing mismatch with the Docker setup
(issue #708).
Change
Removed the unused
hyperledgerExplorerVersionline from the K8s setup.Verification
I ran the generator: the produced K8s
.envdoesn't contain the explorerversion at all (whereas the Docker output does, proving the snapshot test would
catch it if it were used). After removing the line, the K8s snapshot test
passes with byte-identical output, confirming the removal changes nothing.