(fix) Improve error handling and output#781
Open
HarK-github wants to merge 3 commits into
Open
Conversation
Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
… message improvements Signed-off-by: Harshit Kandpal <kandpalhar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #758
This PR addresses minor hardcoded message discrepancies, improves error messaging specificity for config parsing failures, and refactors argument passing in
fabric-docker.shto prevent parameter truncation.Changes:
Validation & Config:
src/commands/validate/index.tsandsrc/config.tsto use a single source of truth (minFabricVersionRaft) for Raft consensus error messages instead of relying on a raw function reference layout.Fablo Config Parser:
src/utils/parseFabloConfig.tsto surface underlying error messages from both the JSON and YAML parser attempts. Added a corresponding unit test inparseFabloConfig.test.ts.Templates & Scripts:
src/setup-docker/templates/fabric-docker.shto use${@:3}and${@:2}syntax instead of strict positional assignments ($3 $4 $5...). This safely relays all extra arguments downstream to chaincode and channel commands.chaincode-scripts.shwhere a validation error for achaincode invokefailure was mistakenly printing "Expected X parameters for chaincode list".Tests: