node: add config validation command#1327
Open
malsomesh9 wants to merge 2 commits into
Open
Conversation
Coverage Report for CI Build 24955777958Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.05%) to 66.915%Details
Uncovered Changes
Coverage Regressions9 previously-covered lines in 5 files lost coverage.
Coverage Stats
💛 - Coveralls |
Signed-off-by: Somesh Mal <malsomesh9@gmail.com>
Signed-off-by: Somesh Mal <malsomesh9@gmail.com>
ecc332f to
161291d
Compare
Contributor
Author
|
@SaidAltury-ibm @mbrandenburger Plz take a look at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
peer validate-configcommand that loads and validates the FSC node configuration before startupfsc.idConfigFileUsed()so the validator can report exactly what it checkedWhy
Today, configuration mistakes are often only discovered later during node startup. This adds a lightweight validation tool that helps contributors and operators catch obvious config issues earlier and see which
core.yamlwas actually loaded.Testing
go test ./node/validatego test ./platform/view/services/configgo test ./node/...Refs #209
Refs #798