node: add safe constructors#1328
Conversation
Signed-off-by: Somesh Mal <malsomesh9@gmail.com>
|
Hey @malsomesh9 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ❌ GPG Signature -- Heads up! The following commits don't have a verified GPG signature:
You'll need to sign your commits with GPG (e.g. ❌ Merge Conflicts -- Oh no, this PR has merge conflicts with the base branch. Let's get this sorted! Update your branch (e.g. rebase or merge from base) and push. See the Merge Conflicts Guide if you need a hand. ❌ Issue Link -- This PR is not linked to any issue. Please reference an issue using a closing keyword (e.g. ⏳ All checks must pass before this PR can be reviewed. You've got this! |
|
Hi @malsomesh9 👋 — the recent merge of PR #1416 has introduced a merge conflict in this PR. Please resolve the merge conflict so that this PR can be reviewed again. Thank you! |
Summary
NewFromConfPathE,NewE,NewWithConfPathE)Why
#183calls out panic-heavy API paths. The node construction flow was one of the clearest user-facing cases: bad config could trigger a panic during setup. This PR introduces safe alternatives without breaking existing callers and starts moving internal code onto the error-returning path.Testing
go test ./pkg/nodego test ./nodego test ./integration/benchmark/nodeRefs #183