fabric: align shared TLS server name override (#1112)#1334
Open
malsomesh9 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Somesh Mal <malsomesh9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
fabric.<network>.tls.serverNameOverrideas the shared Fabric client-side TLS hostname overridefabric.<network>.tls.serverhostoverridekey as a fallback for compatibilityWhy
Issue
#1112is aligning FSC TLS configuration around clearer, more consistent names. The shared Fabric client-side override still used the olderserverhostoverridespelling even though endpoint-level configs and newer docs useserverNameOverride.Impact
Operators can now configure the shared outbound hostname override with the same
serverNameOverridespelling used elsewhere in FSC, without breaking existing configs that still use the legacy key.Validation
go test ./platform/fabric/core/generic/config/... ./platform/fabric/core/generic/membership/...