Skip to content

replace mutex with context aware semaphore#1616

Open
HayimShaul wants to merge 17 commits into
mainfrom
1609-context-aware-mutex
Open

replace mutex with context aware semaphore#1616
HayimShaul wants to merge 17 commits into
mainfrom
1609-context-aware-mutex

Conversation

@HayimShaul
Copy link
Copy Markdown
Contributor

@HayimShaul HayimShaul commented Apr 29, 2026

address issue #1609

@HayimShaul HayimShaul added this to the Q2/26 milestone Apr 29, 2026
@adecaro adecaro force-pushed the 1609-context-aware-mutex branch from f3571af to fa4068e Compare May 5, 2026 05:48
adecaro
adecaro reviewed May 5, 2026
View reviewed changes
Comment thread token/services/storage/auditdb/store.go
// The function respects context cancellation and deadlines, returning an error if the context is cancelled
// or times out before all locks can be acquired. This prevents indefinite blocking and enables fast failure
// in case of lock contention or deadlock scenarios.
func (d *StoreService) AcquireLocks(ctx context.Context, anchor string, eIDs ...string) error {
Copy link
Copy Markdown
Contributor

@adecaro adecaro May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, add unit-tests for this function. Let's make sure the code works as expected. Thanks.

adecaro
adecaro requested changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@adecaro adecaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HayimShaul , please, add unit-tests.

@adecaro adecaro force-pushed the 1609-context-aware-mutex branch from c178394 to 14dc95c Compare May 7, 2026 14:23
@HayimShaul HayimShaul linked an issue May 11, 2026 that may be closed by this pull request
Context-Aware Lock Acquisition with Bounded Hold Time [CRITICAL] #1609
Open
@adecaro
Copy link
Copy Markdown
Contributor

adecaro commented May 12, 2026

Hi @HayimShaul , any update on this? thanks 🙏

Hayim.Shaul@ibm.com and others added 17 commits May 14, 2026 13:21
replace mutex with context aware semaphore
aa50032 
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
lint
2c8a382 
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
added unit-test
57a3fac 
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
fixes
9d3e3ee 
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
lint
fb497e3 
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
lint
c3036a0 
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
@adecaro
fix(cmd-tokengen-unit-tests): do not rewrite existing testdata (#1663)
307ac92 
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
@Soumya8898
Enable self-adjusting (native) histogram buckets for all duration met…
0b7bcf0 
…rics (#1660)

Signed-off-by: Soumya8898 <soumyaranjanmohapatra784@gmail.com>
Signed-off-by: Soumya Mohapatra <mohapatras@microsoft.com>
Co-authored-by: Soumya Mohapatra <mohapatras@microsoft.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
@dependabot
build(deps): Bump github.com/ipld/go-ipld-prime from 0.22.0 to 0.23.0 (…
e1fed98 
…#1694)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
@neetance
perf(bulletproof): optimize ComputeSVector with O(n) dual-butterfly r…
45cdd22 
…ecurrence (#1696)

Signed-off-by: Ankit Basu <ankitbasu14@gmail.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
@atharrva01
feat(ttx): WithApprovalMetadata (#1697)
e566aae 
Signed-off-by: atharrva01 <atharvaborade568@gmail.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
@Rama542
feat(wallet): add context.Context to ListTokens and ListTokensIterator (
07c12ae 
#1689)

Signed-off-by: Rama542 <ramasasankgudipati@gmail.com>
Co-authored-by: Rama542 <Rama542@users.noreply.github.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
@SuyashAlphaC @adecaro
fix(ttx): bind before send on recipient views; remove unused isMeCache (
85ffb4b 
#1628)

Signed-off-by: SuyashAlphaC <suyashagrawal862@gmail.com>
Co-authored-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
@adecaro
bug(balance): to return big.Int to avoid overflows (#1692)
d3be88c 
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
@adecaro
dep cleanup (#1676)
fa240b3 
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
@SuyashAlphaC
fix(multisig,boolpolicy): verify spend tx matches approved SpendReque…
b2f2c68 
…st (#1691)

Signed-off-by: SuyashAlphaC <suyashagrawal862@gmail.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
@adecaro
fsc v0.11.0 (#1702)
14cd156 
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
@HayimShaul HayimShaul force-pushed the 1609-context-aware-mutex branch from 6c8dd3d to 14cd156 Compare May 14, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adecaro adecaro adecaro requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

security

Projects

None yet

Milestone

Q2/26

Development

Successfully merging this pull request may close these issues.

Context-Aware Lock Acquisition with Bounded Hold Time [CRITICAL]

7 participants

@HayimShaul @adecaro @Soumya8898 @neetance @atharrva01 @Rama542 @SuyashAlphaC