fix: resolve compiler panic with large exponent constant rationals#1885
Open
ParthSinghPS wants to merge 1 commit intohyperledger-solang:mainfrom
Open
fix: resolve compiler panic with large exponent constant rationals#1885ParthSinghPS wants to merge 1 commit intohyperledger-solang:mainfrom
ParthSinghPS wants to merge 1 commit intohyperledger-solang:mainfrom
Conversation
Signed-off-by: ParthSinghPS <posiedon.1721@gmail.com>
eafca11 to
d5e7842
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1881
Description
The compiler was occasionally panicking with
Option::unwrap() on a None valuein eval_const_rational when a constant with a large scientific-notation exponent (e.g.0e1000) was used in a rational type context (such as array bounds).When the parser builds the AST, number_literal() correctly rejects an exponent as too large, leaving the constant variable's
initializerasNone. However, later evaluations simply used.unwrap()on the initializer. This PR replaces those calls with properif let Someerror handling, returning aDiagnosticinstead.Changes
ConstantVariableevaluation branches.