Skip to content

add hello_world example for String and Vec<String>#1902

Merged
mohamedbasuony merged 2 commits into
hyperledger-solang:mainfrom
sengmonkham:soroban-hello-world
May 13, 2026
Merged

add hello_world example for String and Vec<String>#1902
mohamedbasuony merged 2 commits into
hyperledger-solang:mainfrom
sengmonkham:soroban-hello-world

Conversation

@sengmonkham
Copy link
Copy Markdown
Contributor

#1901
This PR adds the hello_world integration test to the Soroban test suite, addressing one of the missing upstream Soroban examples.

@mohamedbasuony
Copy link
Copy Markdown
Contributor

Thanks for the PR. The checks are still red: DCO is failing and the Linux x86-64 build/test job is also failing. Please sign off the commit and fix the Linux CI failure, then push an update.

@mohamedbasuony mohamedbasuony self-requested a review May 13, 2026 11:43
@sengmonkham sengmonkham force-pushed the soroban-hello-world branch 2 times, most recently from db9f6f8 to bfc2314 Compare May 13, 2026 16:58
… coverage

Signed-off-by: sen <kawkoi@proton.me>
@sengmonkham sengmonkham force-pushed the soroban-hello-world branch from bfc2314 to b9bccbf Compare May 13, 2026 18:08
@mohamedbasuony mohamedbasuony merged commit b6497a0 into hyperledger-solang:main May 13, 2026
7 of 8 checks passed
@sengmonkham
Copy link
Copy Markdown
Contributor Author

@mohamedbasuony Thanks for merging my PR!

Just a quick heads-up: I added the @babel/core dev dependency to vscode/package.json in this PR because the VS Code extension tests were failing in the CI with the following error:

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@babel/core' imported from /home/runner/work/solang/solang/vscode/node_modules/reghex/src/babel/plugin.test.js

This failure was completely unrelated to the hello_world example but was blocking the CI pipeline. If this was an environment issue on the CI rather than a genuinely missing dependency, please let me know if you'd like me to revert it in a separate follow-up PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants