Skip to content

fix(soroban): reject unsupported ABI types before codegen #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohamedbasuony wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(soroban): reject unsupported ABI types before codegen #1903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/codegen/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,18 @@ fn contract(contract_no: usize, ns: &mut Namespace, opt: &Options) {
if !ns.diagnostics.any_errors() && ns.contracts[contract_no].instantiable {
layout(contract_no, ns);

if ns.target == Target::Soroban {
soroban::validate_accessor_abi_types(contract_no, ns);
if ns.diagnostics.any_errors() {
return;
}

soroban::validate_event_abi_types(contract_no, ns);
if ns.diagnostics.any_errors() {
return;
}
}

let mut cfg_no = 0;
let mut all_cfg = Vec::new();

Expand Down Expand Up @@ -359,6 +371,13 @@ fn contract(contract_no: usize, ns: &mut Namespace, opt: &Options) {
ns.contracts[contract_no].default_constructor = Some((func, cfg_no));
}

if ns.target == Target::Soroban {
soroban::validate_abi_types(&all_cfg, ns);
if ns.diagnostics.any_errors() {
return;
}
}

for mut dispatch_cfg in function_dispatch(contract_no, &mut all_cfg, ns, opt) {
optimize_and_check_cfg(&mut dispatch_cfg, ns, ASTFunction::None, opt);
all_cfg.push(dispatch_cfg);
Expand Down
Loading
Loading