Standardize usage of CCID instead of CCNAME across samples#805
Merged
Conversation
Contributor
Author
|
@mbrandenburger @chenchanglew can you guys check to see if I have identified all the places where it would need to be updated? I still have to test it ... |
mbrandenburger
requested changes
May 20, 2025
Contributor
mbrandenburger
left a comment
mbrandenburger
left a comment
There was a problem hiding this comment.
Thanks @munapower - I did a quick pass and left a few comments. As you mentioned offline there are several issues with the k8 sample - we can focus on those issues in another PR if you like.
Improve simple-testing-network to check if monitoring should be enabled or not. Fix docker tag issues and add note to readme Small fix to minikube readme and CA image Signed-off-by: munapower <mmunaro@hotmail.com>
munapower
force-pushed
the
fixCCinFpcclient
branch
from
dcedd56 to
424a80f
Compare
mbrandenburger
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There are 2 environment variables being used CCID and CCNAME. CCNAME is the name the docker image will have. CCID is used to reference the chaincode name. Samples should be using CCID.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing changes and/or breaks backward compatability?:
Yes, readme's are updated.