Skip to content

[docker] Fix Test-Node default activation#401

Merged
dean-amar merged 31 commits into
hyperledger:mainfrom
dean-amar:default-test-node-startup-setup
Mar 17, 2026
Merged

[docker] Fix Test-Node default activation#401
dean-amar merged 31 commits into
hyperledger:mainfrom
dean-amar:default-test-node-startup-setup

Conversation

@dean-amar
Copy link
Copy Markdown
Contributor

@dean-amar dean-amar commented Mar 3, 2026

Type of change

  • Bug fix
  • Test update

Description

This PR configures TLS certificate paths from the config block for all services in the test node Docker image, enabling proper mTLS communication between components by default.

Related issues

Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
@dean-amar dean-amar marked this pull request as ready for review March 3, 2026 12:47
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 3, 2026

Coverage Status

coverage: 90.488% (+0.3%) from 90.219%
when pulling f159ad5 on dean-amar:default-test-node-startup-setup
into 15fdd75 on hyperledger:main.

Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
@dean-amar dean-amar requested a review from liran-funaro March 3, 2026 13:20
@dean-amar dean-amar added the bug Something isn't working label Mar 3, 2026
@dean-amar dean-amar requested a review from cendhu March 3, 2026 13:35
@dean-amar dean-amar changed the title [docker] Test-Node default activation fixage [docker] Fix Test-Node default activation Mar 3, 2026
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
@dean-amar dean-amar requested review from cendhu and liran-funaro and removed request for cendhu and liran-funaro March 9, 2026 16:36
Comment thread docker/images/test_node/Dockerfile Outdated
Comment thread cmd/config/samples/mock-orderer.yaml
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Comment thread cmd/config/app_config_test.go Outdated
Comment thread utils/testcrypto/gen_crypto.go Outdated
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Comment thread cmd/config/samples/coordinator.yaml
Comment thread cmd/config/samples/coordinator.yaml Outdated
Comment thread cmd/config/samples/coordinator.yaml Outdated
Comment thread cmd/config/app_config_test.go Outdated
Comment thread cmd/config/app_config_test.go Outdated
Comment thread docker/test/common.go Outdated
Comment thread utils/testcrypto/gen_crypto.go
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
All database instances now share the same pre-generated TLS credentials.
The `chown root:root /creds/*` command caused race conditions when multiple
parallel test instances modified the same shared certificate files,
leading to intermittent YugabyteDB startup hangs.

Removed the unnecessary chown commands since Docker bind mounts handle
file permissions automatically.

Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Comment thread cmd/config/samples/loadgen.yaml Outdated
Comment thread cmd/config/samples/mock-orderer.yaml
Comment thread cmd/config/samples/sidecar.yaml Outdated
Comment thread cmd/config/app_config_test.go
Comment thread docker/test/common.go Outdated
Comment thread docker/test/container_test.go Outdated
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
@dean-amar dean-amar requested a review from liran-funaro March 16, 2026 12:40
Comment thread cmd/config/samples/sidecar.yaml Outdated
Comment thread utils/test/utils.go Outdated
Comment thread utils/test/utils.go Outdated
Comment thread utils/testdb/container.go Outdated
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Comment thread cmd/config/samples/loadgen.yaml Outdated
Comment thread cmd/config/samples/sidecar.yaml Outdated
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Comment thread utils/test/utils.go Outdated
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Comment thread docker/test/container_test.go Outdated
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
@dean-amar dean-amar requested a review from liran-funaro March 16, 2026 15:09
Copy link
Copy Markdown
Contributor

@liran-funaro liran-funaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread cmd/config/samples/sidecar.yaml Outdated
@liran-funaro
Copy link
Copy Markdown
Contributor

@dean-amar please rebase

Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
@dean-amar dean-amar merged commit 59fc208 into hyperledger:main Mar 17, 2026
17 checks passed
@dean-amar dean-amar deleted the default-test-node-startup-setup branch March 17, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing

Projects

None yet

4 participants