Fix dissemination failure despite satisfying RequiredPeerCount#5502
Open
drupadh-dinesh wants to merge 1 commit into
Open
Fix dissemination failure despite satisfying RequiredPeerCount#5502drupadh-dinesh wants to merge 1 commit into
drupadh-dinesh wants to merge 1 commit into
Conversation
4509add to
00aef3d
Compare
Signed-off-by: Drupadh Dinesh <drupadhdinesh@gmail.com>
00aef3d to
a4673c7
Compare
Contributor
Author
|
Hi @pfi79 , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Previously, private data dissemination created multiple dissemination plans and assigned acknowledgement requirements (MinAck) to specific peers. As a result, dissemination could fail when an acknowledgement was not received from one of the designated peers, even if acknowledgements from other selected peers satisfied the collection's RequiredPeerCount.
This change updates dissemination planning to:
Additional details
Implementation changes include: