remove config option

Signed-off-by: hfuss <hayden.fuss@kaleido.io>

Author: onelapahead

pkg/dbsql/config.go

@@ -37,8 +37,6 @@ const (
 	SQLConfMaxIdleConns = "maxIdleConns"
 	// SQLConfMaxConnLifetime maximum connections to the database
 	SQLConfMaxConnLifetime = "maxConnLifetime"
-	// SQLConfMaxPlaceholders overrides the provider's max SQL placeholders per statement (0 = use provider default)
-	SQLConfMaxPlaceholders = "maxPlaceholders"
 )
 
 const (
@@ -53,5 +51,4 @@ func (s *Database) InitConfig(provider Provider, config config.Section) {
 	config.AddKnownKey(SQLConfMaxConnIdleTime, "1m")
 	config.AddKnownKey(SQLConfMaxIdleConns) // defaults to the max connections
 	config.AddKnownKey(SQLConfMaxConnLifetime)
-	config.AddKnownKey(SQLConfMaxPlaceholders) // overrides provider default for max SQL placeholders
 }

pkg/dbsql/database.go

@@ -80,10 +80,6 @@ func (s *Database) Init(ctx context.Context, provider Provider, config config.Se
 	s.features = s.provider.Features()
 	s.sequenceColumn = s.provider.SequenceColumn()
 
-	if maxPlaceholders := config.GetInt(SQLConfMaxPlaceholders); maxPlaceholders > 0 {
-		s.features.MaxPlaceholders = maxPlaceholders
-	}
-
 	if config.GetString(SQLConfDatasourceURL) == "" {
 		return i18n.NewError(ctx, i18n.MsgMissingConfig, "url", fmt.Sprintf("database.%s", s.provider.Name()))
 	}

pkg/dbsql/database_test.go

@@ -78,16 +78,6 @@ func TestInitDatabaseFeatures(t *testing.T) {
 	assert.Equal(t, false, s.Features().MultiRowInsert)
 }
 
-func TestInitDatabaseMaxPlaceholdersConfig(t *testing.T) {
-	s := &Database{}
-	tp := NewMockProvider()
-	s.InitConfig(tp, tp.config)
-	tp.config.Set(SQLConfMaxPlaceholders, 1000)
-	err := s.Init(context.Background(), tp, tp.config)
-	assert.NoError(t, err)
-	assert.Equal(t, 1000, s.Features().MaxPlaceholders)
-}
-
 func TestInitDatabaseMaxPlaceholdersProviderDefault(t *testing.T) {
 	mp := NewMockProvider()
 	mp.MaxPlaceholders = 65535