Update btcec dependency to v2.3.5 and fix signature error handling#95
Merged
Conversation
Signed-off-by: David Wertenteil <david.wertenteil@kaleido.io>
dwertent
force-pushed
the
bump-btcec
branch
from
bb50a90 to
b9f63ba
Compare
EnriqueL8
reviewed
Sep 17, 2025
Contributor
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
A few comments - would need a test if we keep that check
Signed-off-by: David Wertenteil <david.wertenteil@kaleido.io>
Contributor
|
The underlying library has removed the error from SignCompact() as it was always |
EnriqueL8
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.