fix: test has race condition on ws before connect with DX callbacks#1658
Merged
peterbroadhurst merged 2 commits intomainfrom Mar 13, 2025
Merged
fix: test has race condition on ws before connect with DX callbacks#1658peterbroadhurst merged 2 commits intomainfrom
peterbroadhurst merged 2 commits intomainfrom
Conversation
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
8 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1658 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 339 339
Lines 29780 29780
=======================================
Hits 29768 29768
Misses 8 8
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
onelapahead
approved these changes
Mar 12, 2025
peterbroadhurst
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #1636 (comment)
h.Start()create the WS connection and in the before connect we added a callback handlerDXConnect(). The test used to connect then add the handlers so sometimes the test might take longer so on reconnect the handler would be there but not the DXConnect mock.Actually the test should add all the handlers before staring the FFDX plugin, this is the fix.
FYI @onelapahead
Types of changes
Please make sure to follow these points