Skip to content

Commit 95d7349

Browse files
committed
Avoid quoting issues
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
1 parent 7fbd730 commit 95d7349

4 files changed

Lines changed: 18 additions & 11 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,8 @@ jobs:
209209

210210
- name: Build all Python packages
211211
run: |
212-
INTERPS="--interpreter $(uv python find 3.10) $(uv python find 3.11) $(uv python find 3.12) $(uv python find 3.13)"
213-
just python-dist interpreters="$INTERPS"
212+
export INTERPRETERS="--interpreter $(uv python find 3.10) $(uv python find 3.11) $(uv python find 3.12) $(uv python find 3.13)"
213+
just python-dist
214214
215215
- uses: actions/upload-artifact@v4
216216
with:
@@ -244,7 +244,8 @@ jobs:
244244
shell: pwsh
245245
run: |
246246
$interps = "3.10", "3.11", "3.12", "3.13" | ForEach-Object { & uv python find $_ }
247-
just python-dist-backends interpreters="--interpreter $($interps -join ' ')"
247+
$env:INTERPRETERS = "--interpreter $($interps -join ' ')"
248+
just python-dist-backends
248249
249250
- uses: actions/upload-artifact@v4
250251
with:

.github/workflows/publish.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ jobs:
4141

4242
- name: Build all Python packages
4343
run: |
44-
INTERPS="--interpreter $(uv python find 3.10) $(uv python find 3.11) $(uv python find 3.12) $(uv python find 3.13)"
45-
just python-dist interpreters="$INTERPS"
44+
export INTERPRETERS="--interpreter $(uv python find 3.10) $(uv python find 3.11) $(uv python find 3.12) $(uv python find 3.13)"
45+
just python-dist
4646
4747
- uses: actions/upload-artifact@v4
4848
with:
@@ -77,7 +77,8 @@ jobs:
7777
shell: pwsh
7878
run: |
7979
$interps = "3.10", "3.11", "3.12", "3.13" | ForEach-Object { & uv python find $_ }
80-
just python-dist-backends interpreters="--interpreter $($interps -join ' ')"
80+
$env:INTERPRETERS = "--interpreter $($interps -join ' ')"
81+
just python-dist-backends
8182
8283
- uses: actions/upload-artifact@v4
8384
with:

Justfile

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,13 @@ test-rust:
4141

4242
benchmark: python::python-sandbox-benchmark
4343

44-
python-dist interpreters="": (wasm::build "release") (js::build "release") (python::python-dist interpreters)
44+
python-dist: (wasm::build "release") (js::build "release")
45+
just python python-dist
4546

46-
python-dist-backends interpreters="": wasm::_clean-stale-wasm wasm::guest-compile-wit js::_clean-stale
47+
python-dist-backends: wasm::_clean-stale-wasm wasm::guest-compile-wit js::_clean-stale
4748
cargo build --manifest-path src/wasm_sandbox/Cargo.toml --release
4849
cargo build --manifest-path src/javascript_sandbox/Cargo.toml --release
49-
just python python-dist-backends interpreters="{{interpreters}}"
50+
just python python-dist-backends
5051

5152
python-wheelhouse-test: python-dist python::python-wheelhouse-test
5253

src/sdk/python/Justfile

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ export WIT_WORLD := repo-root + "/src/wasm_sandbox/wit/sandbox-world.wasm"
55
rmrf := if os() == "windows" { "Remove-Item -Recurse -Force -ErrorAction SilentlyContinue" } else { "rm -rf" }
66
mkdirp := if os() == "windows" { "New-Item -ItemType Directory -Force" } else { "mkdir -p" }
77

8+
# Set via env or CLI (e.g. `just interpreters="--interpreter python3.10 python3.13" python-dist`)
9+
# to build wheels for multiple Python versions. Defaults to empty (maturin uses active Python).
10+
interpreters := env("INTERPRETERS", "")
11+
812
dist-root := repo-root + "/dist/pythonsdk"
913
core-dist := dist-root + "/core"
1014
wasm-wheels := dist-root + "/wasm_backend"
@@ -50,7 +54,7 @@ build: python-build
5054

5155
#### DIST / PUBLISH ####
5256

53-
python-dist interpreters="": python-sync-guest-resources
57+
python-dist: python-sync-guest-resources
5458
-{{rmrf}} {{dist-root}}
5559
cd {{repo-root}}/src/sdk/python/core && uv run python -m build --outdir {{core-dist}}
5660
cd {{repo-root}}/src/sdk/python/wasm_backend && uv run maturin build --release --out {{wasm-wheels}} {{interpreters}}
@@ -61,7 +65,7 @@ python-dist interpreters="": python-sync-guest-resources
6165
# Build only the platform-specific maturin backend wheels.
6266
# Used by CI to produce Windows wheels without needing guest binaries.
6367
# Requires sandbox-world.wasm to exist (run `just wasm guest-compile-wit` first).
64-
python-dist-backends interpreters="": python-sync-env
68+
python-dist-backends: python-sync-env
6569
-{{rmrf}} {{wasm-wheels}}
6670
-{{rmrf}} {{hyperlight-js-wheels}}
6771
cd {{repo-root}}/src/sdk/python/wasm_backend && uv run maturin build --release --out {{wasm-wheels}} {{interpreters}}

0 commit comments

Comments
 (0)