Skip to content

Commit 04efd41

Browse files
committed
fix: return error for unsupported socket options instead of silent no-op
Signed-off-by: danbugs <danilochiarlone@gmail.com>
1 parent 5a5a32e commit 04efd41

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

host/src/lib.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1180,14 +1180,14 @@ fn register_net_tools(
11801180
// SOL_SOCKET=1, SO_REUSEADDR=2
11811181
if level == 1 && optname == 2 {
11821182
sock.set_reuse_address(value != 0)?;
1183-
}
11841183
// SOL_SOCKET=1, SO_KEEPALIVE=9
1185-
if level == 1 && optname == 9 {
1184+
} else if level == 1 && optname == 9 {
11861185
sock.set_keepalive(value != 0)?;
1187-
}
11881186
// IPPROTO_TCP=6, TCP_NODELAY=1
1189-
if level == 6 && optname == 1 {
1187+
} else if level == 6 && optname == 1 {
11901188
sock.set_nodelay(value != 0)?;
1189+
} else {
1190+
return Err(anyhow!("unsupported socket option: level={}, optname={}", level, optname));
11911191
}
11921192
Ok(json!({}))
11931193
});
@@ -1208,7 +1208,7 @@ fn register_net_tools(
12081208
} else if level == 6 && optname == 1 {
12091209
sock.nodelay()? as i32
12101210
} else {
1211-
0
1211+
return Err(anyhow!("unsupported socket option: level={}, optname={}", level, optname));
12121212
};
12131213
Ok(json!({ "value": val }))
12141214
});

0 commit comments

Comments
 (0)