Skip to content

Commit 0e89d96

Browse files
committed
fix: return error for unsupported socket options instead of silent no-op
Signed-off-by: danbugs <danilochiarlone@gmail.com>
1 parent 29bfad6 commit 0e89d96

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

host/src/lib.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1106,14 +1106,14 @@ fn register_net_tools(
11061106
// SOL_SOCKET=1, SO_REUSEADDR=2
11071107
if level == 1 && optname == 2 {
11081108
sock.set_reuse_address(value != 0)?;
1109-
}
11101109
// SOL_SOCKET=1, SO_KEEPALIVE=9
1111-
if level == 1 && optname == 9 {
1110+
} else if level == 1 && optname == 9 {
11121111
sock.set_keepalive(value != 0)?;
1113-
}
11141112
// IPPROTO_TCP=6, TCP_NODELAY=1
1115-
if level == 6 && optname == 1 {
1113+
} else if level == 6 && optname == 1 {
11161114
sock.set_nodelay(value != 0)?;
1115+
} else {
1116+
return Err(anyhow!("unsupported socket option: level={}, optname={}", level, optname));
11171117
}
11181118
Ok(json!({}))
11191119
});
@@ -1134,7 +1134,7 @@ fn register_net_tools(
11341134
} else if level == 6 && optname == 1 {
11351135
sock.nodelay()? as i32
11361136
} else {
1137-
0
1137+
return Err(anyhow!("unsupported socket option: level={}, optname={}", level, optname));
11381138
};
11391139
Ok(json!({ "value": val }))
11401140
});

0 commit comments

Comments
 (0)