Skip to content

Commit 50d57e9

Browse files
committed
fix: skip initrd on restore, avoid pyarrow string path in benchmark
Signed-off-by: danbugs <danilochiarlone@gmail.com>
1 parent a5e058a commit 50d57e9

3 files changed

Lines changed: 5 additions & 12 deletions

File tree

.github/workflows/benchmarks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ jobs:
216216
echo "=== Pandas — DataFrame.describe() ==="
217217
cat > /tmp/pandas_bench.py << 'PYEOF'
218218
import pandas as pd, numpy as np
219-
df = pd.DataFrame(np.random.randn(1000, 4), columns=list('ABCD'))
219+
df = pd.DataFrame(np.random.randn(1000, 4))
220220
print(df.describe())
221221
PYEOF
222222
pyhl run /tmp/pandas_bench.py > /dev/null || { echo "FAIL: pandas smoke check failed"; exit 1; }
@@ -410,7 +410,7 @@ jobs:
410410
Write-Host "=== Pandas — DataFrame.describe() ==="
411411
@"
412412
import pandas as pd, numpy as np
413-
df = pd.DataFrame(np.random.randn(1000, 4), columns=list('ABCD'))
413+
df = pd.DataFrame(np.random.randn(1000, 4))
414414
print(df.describe())
415415
"@ | Out-File -Encoding ascii pandas_bench.py
416416
$times = @()

host/src/bin/pyhl.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -593,12 +593,11 @@ fn cmd_run(args: RunArgs) -> Result<()> {
593593
listen_ports.is_some(),
594594
)?;
595595

596-
let initrd = home.join(INITRD_FILE);
597596
let t_load = Instant::now();
598597
let mut sandbox = Sandbox::from_snapshot_file_configured(
599598
&snapshot,
600599
&run_preopens,
601-
Some(&initrd),
600+
None,
602601
network.as_ref(),
603602
listen_ports.as_ref(),
604603
)?;

host/src/pyhl.rs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -274,14 +274,8 @@ impl Runtime {
274274
snap.display()
275275
);
276276
}
277-
let initrd = home.join(INITRD_FILE);
278-
let sandbox = Sandbox::from_snapshot_file_configured(
279-
&snap,
280-
mounts,
281-
Some(&initrd),
282-
network,
283-
listen_ports,
284-
)?;
277+
let sandbox =
278+
Sandbox::from_snapshot_file_configured(&snap, mounts, None, network, listen_ports)?;
285279
Ok(Self {
286280
sandbox,
287281
first_run: true,

0 commit comments

Comments
 (0)