Skip to content

ci: trigger cargo publish from release workflow - #103

Merged
danbugs merged 1 commit into
mainfrom
fix/release-triggers-cargo-publish
Jun 27, 2026
Merged

ci: trigger cargo publish from release workflow#103
danbugs merged 1 commit into
mainfrom
fix/release-triggers-cargo-publish

Conversation

@danbugs

@danbugs danbugs commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add cargo-publish.yml dispatch to release.yml (same pattern as GHCR image publish)
  • Remove dead on: release trigger from cargo-publish.yml — releases created by GITHUB_TOKEN don't fire on: release events

Test plan

  • Verified manually: v0.11.0 required manual workflow_dispatch to publish to crates.io
  • CI passes

GITHUB_TOKEN-created releases don't fire on:release triggers,
so dispatch cargo-publish.yml directly from release.yml (same
pattern as GHCR image publish).

Signed-off-by: danbugs <danilochiarlone@gmail.com>
Copilot AI review requested due to automatic review settings June 27, 2026 08:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release automation so the crates.io publish workflow is triggered directly from the release workflow, avoiding reliance on on: release (which doesn’t fire for releases created via GITHUB_TOKEN).

Changes:

  • Dispatch cargo-publish.yml from release.yml at the end of the release job.
  • Remove the on: release trigger from cargo-publish.yml, leaving it workflow_dispatch-only.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/release.yml Adds a step to trigger the crates.io publish workflow via gh workflow run on the release tag ref.
.github/workflows/cargo-publish.yml Removes the release event trigger so publishing is driven by explicit workflow dispatch.
Comments suppressed due to low confidence (1)

.github/workflows/cargo-publish.yml:10

  • With the on: release trigger removed, this workflow can no longer run in a release event context, but later steps still branch on ${{ github.event_name }} == "release" to force dry_run=false. That conditional is now unreachable and can mislead future changes; consider simplifying the workflow to always derive dry_run from inputs.dry_run (and rely on the caller—release.yml—to pass dry_run=false when publishing).
on:
  workflow_dispatch:
    inputs:
      dry_run:
        description: "Run without actually publishing"
        type: boolean
        default: true


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux Benchmarks

Details
Benchmark suite Current: 1ee87eb Previous: 682ad20 Ratio
hello_world (median) 20 ms 20 ms 1
pandas (median) 110 ms 120 ms 0.92
density (per VM) 8 MB 8 MB 1
snapshot (disk) 653 MiB 653 MiB 1

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows Benchmarks

Details
Benchmark suite Current: 1ee87eb Previous: 682ad20 Ratio
hello_world (median) 315 ms 291 ms 1.08
pandas (median) 977 ms 1024 ms 0.95
density (per VM) 7 MB 7 MB 1
snapshot (disk) 661 MiB 661 MiB 1

This comment was automatically generated by workflow using github-action-benchmark.

@danbugs
danbugs merged commit f1c1281 into main Jun 27, 2026
88 checks passed
@danbugs
danbugs deleted the fix/release-triggers-cargo-publish branch June 27, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants