feat: add pyhl container image for device plugin deployments - #109
Merged
Conversation
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR introduces a new runnable pyhl container image intended for hyperlight-on-kubernetes device plugin deployments, and wires it into the existing GHCR publishing workflow.
Changes:
- Adds a multi-stage Dockerfile that bundles the
pyhlCLI plus the python-agent-driver kernel + initrd into a single container image. - Adds a container entrypoint that runs
pyhl setupon first start (or supports--setup-onlyfor init container usage) and then executespyhl run. - Extends the existing GHCR publish workflow to build and push the
pyhlimage whenhost/**(and other relevant paths) change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
host/pyhl.Dockerfile |
Builds a minimal runtime container bundling pyhl with the published kernel/initrd artifacts. |
host/pyhl-entrypoint.sh |
Bootstraps the pyhl install/snapshot on first run and supports --setup-only for init containers. |
.github/workflows/publish-examples.yml |
Adds a publish-pyhl job and triggers publishing when host/** changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Linux Benchmarks
Details
| Benchmark suite | Current: 76b2a9c | Previous: 71c543b | Ratio |
|---|---|---|---|
hello_world (median) |
20 ms |
20 ms |
1 |
pandas (median) |
110 ms |
110 ms |
1 |
density (per VM) |
12 MB |
12 MB |
1 |
snapshot (disk) |
701 MiB |
701 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Contributor
There was a problem hiding this comment.
Windows Benchmarks
Details
| Benchmark suite | Current: 76b2a9c | Previous: 71c543b | Ratio |
|---|---|---|---|
hello_world (median) |
425 ms |
382 ms |
1.11 |
pandas (median) |
1216 ms |
1048 ms |
1.16 |
density (per VM) |
11 MB |
11 MB |
1 |
snapshot (disk) |
727 MiB |
727 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyhl+ the python-agent-driver kernel + initrd into a single runnable container (ghcr.io/hyperlight-dev/hyperlight-unikraft/pyhl:latest)publish-pyhljob to the GHCR publish workflow, triggered by changes tohost/,examples/,runtimes/, or the workflow itself/dev/kvmviahyperlight.dev/hypervisor: "1"and pyhl handles VM lifecycle internally--setup-onlyflag for use as a Kubernetes init container, separating warmup from script execution