ci: unique umbrella job names for branch protection - #19
Merged
Conversation
Rename all-checks-passed to host-checks-passed, benchmarks-passed, and test-examples-passed so branch protection can require each individually — prevents auto-merge from triggering when only the fastest workflow completes. Signed-off-by: danbugs <danilochiarlone@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Linux Benchmarks
Details
| Benchmark suite | Current: b59826c | Previous: 9d37a86 | Ratio |
|---|---|---|---|
hello_world (median) |
20 ms |
20 ms |
1 |
pandas (median) |
100 ms |
100 ms |
1 |
density (per VM) |
6 MB |
6 MB |
1 |
snapshot (disk) |
648 MiB |
648 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
When Swatinem/rust-cache restores cached fingerprints but not the surrogate exe, Cargo skips the build script and RustEmbed fails. Clear hyperlight-host fingerprints when the surrogate is missing so the build script re-runs. Signed-off-by: danbugs <danilochiarlone@gmail.com>
Contributor
There was a problem hiding this comment.
Windows Benchmarks
Details
| Benchmark suite | Current: b59826c | Previous: 9d37a86 | Ratio |
|---|---|---|---|
hello_world (median) |
227 ms |
261 ms |
0.87 |
pandas (median) |
784 ms |
895 ms |
0.88 |
density (per VM) |
6 MB |
6 MB |
1 |
snapshot (disk) |
673 MiB |
673 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Linux: replace pwsh Copy-Item (USERPROFILE is unset) with cp to /usr/local/bin. Windows: add surrogate build consistency check (was missing from the matrix job, only runtime-test-windows had it). Signed-off-by: danbugs <danilochiarlone@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
all-checks-passedtohost-checks-passed,benchmarks-passed, andtest-examples-passedacross the three workflow filesall-checks-passedto complete (host-checks, ~1 min) and merged before benchmarks and test-examples finished