fix: restore surrogate default in pyhl binary main() - #24
Merged
Conversation
Signed-off-by: danbugs <danilochiarlone@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Linux Benchmarks
Details
| Benchmark suite | Current: 1a15b27 | Previous: 8affbcc | Ratio |
|---|---|---|---|
hello_world (median) |
20 ms |
20 ms |
1 |
pandas (median) |
100 ms |
100 ms |
1 |
density (per VM) |
7 MB |
7 MB |
1 |
snapshot (disk) |
384 MiB |
384 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Windows Benchmarks
Details
| Benchmark suite | Current: 1a15b27 | Previous: 8affbcc | Ratio |
|---|---|---|---|
hello_world (median) |
259 ms |
899 ms |
0.29 |
pandas (median) |
897 ms |
1508 ms |
0.59 |
density (per VM) |
6 MB |
6 MB |
1 |
snapshot (disk) |
392 MiB |
392 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: danbugs <danilochiarlone@gmail.com>
danbugs
enabled auto-merge
May 14, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #22 moved
default_surrogate_count()from the pyhl binary'smain()into the library functions (install()andRuntime::new()). However, the binary'scmd_run()callsSandbox::from_snapshot_file_configured()directly — bypassing both library entry points. This leftHYPERLIGHT_INITIAL_SURROGATESunset forpyhl run, causing Hyperlight to pre-spawn all 512 surrogate processes (~3.5s on Windows).default_surrogate_count()public in the librarymain()in the binary so bothsetupandrunpaths are coveredBenchmark impact