host: add --port flag for inbound listen-port allowlist - #26
Merged
Conversation
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Contributor
There was a problem hiding this comment.
Linux Benchmarks
Details
| Benchmark suite | Current: 1c303ff | Previous: 0eb9887 | Ratio |
|---|---|---|---|
hello_world (median) |
20 ms |
20 ms |
1 |
pandas (median) |
110 ms |
100 ms |
1.10 |
density (per VM) |
7 MB |
7 MB |
1 |
snapshot (disk) |
385 MiB |
385 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Contributor
There was a problem hiding this comment.
Windows Benchmarks
Details
| Benchmark suite | Current: 1c303ff | Previous: 0eb9887 | Ratio |
|---|---|---|---|
hello_world (median) |
276 ms |
271 ms |
1.02 |
pandas (median) |
884 ms |
850 ms |
1.04 |
density (per VM) |
6 MB |
6 MB |
1 |
snapshot (disk) |
393 MiB |
393 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListenPortstype — an allowlist of ports the guest may bind to for inbound connections--port PORTCLI flag (repeatable) tohyperlight-unikraftandpyhl(bothsetupandrun)net_bindis now gated: without--port, bind is rejected withEACCES; with--port 8080, only port 8080 is allowed--portimplies--net, so--port 8080alone enables networking + inbound on that port--netalone enables outbound-only (no bind/listen)networking-pyJustfile:run-echonow uses--port 8080This makes inbound networking opt-in and explicit, matching the existing pattern where
--net/--net-allow/--net-blockgate outbound.Test plan
cargo test— 35 unit tests pass (4 new: ListenPorts permit/deny, net_bind with/without allowlist)--port 8080+ echo_server.py — bind succeeds, echo works end-to-end--netalone + echo_server.py — bind fails withOSError--port 8080+ inline bind to 9090 — 8080 succeeds, 9090 fails--portwithout--net— networking is implicitly enabled