fix: block link-local addresses by default in NetworkPolicy - #54
Merged
Conversation
Signed-off-by: danbugs <danilochiarlone@gmail.com>
danbugs
enabled auto-merge
May 15, 2026 23:54
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Linux Benchmarks
Details
| Benchmark suite | Current: 188e138 | Previous: a4831d7 | Ratio |
|---|---|---|---|
hello_world (median) |
20 ms |
20 ms |
1 |
pandas (median) |
100 ms |
110 ms |
0.91 |
density (per VM) |
7 MB |
7 MB |
1 |
snapshot (disk) |
385 MiB |
385 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Windows Benchmarks
Details
| Benchmark suite | Current: 188e138 | Previous: a4831d7 | Ratio |
|---|---|---|---|
hello_world (median) |
177 ms |
255 ms |
0.69 |
pandas (median) |
519 ms |
829 ms |
0.63 |
density (per VM) |
6 MB |
6 MB |
1 |
snapshot (disk) |
392 MiB |
392 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
169.254.0.0/16(IPv4) andfe80::/10(IPv6) at the top ofNetworkPolicy::check(), before the policy-variant match — applies to AllowAll, BlockList, and AllowList alike169.254.169.254) which hands out credentials without authentication; every major container/VM runtime (Docker, Firecracker, gVisor) blocks this by defaultnet_link_local_blockedtest covering both address families under AllowAll and BlockList policiesTest plan
cargo test --lib net_link_local_blockedpassescargo test --lib(49 tests) passescargo fmtandcargo clippyclean