fix: cap SocketTable size and clear on restore - #55
Merged
Conversation
Signed-off-by: danbugs <danilochiarlone@gmail.com>
danbugs
enabled auto-merge
May 15, 2026 23:54
Contributor
There was a problem hiding this comment.
Linux Benchmarks
Details
| Benchmark suite | Current: 56f8710 | Previous: a4831d7 | Ratio |
|---|---|---|---|
hello_world (median) |
20 ms |
20 ms |
1 |
pandas (median) |
110 ms |
110 ms |
1 |
density (per VM) |
7 MB |
7 MB |
1 |
snapshot (disk) |
385 MiB |
385 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Windows Benchmarks
Details
| Benchmark suite | Current: 56f8710 | Previous: a4831d7 | Ratio |
|---|---|---|---|
hello_world (median) |
243 ms |
255 ms |
0.95 |
pandas (median) |
844 ms |
829 ms |
1.02 |
density (per VM) |
6 MB |
6 MB |
1 |
snapshot (disk) |
392 MiB |
392 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SocketTableat 1024 entries (MAX_SOCKETS) —insert()now returnsResult<u64>and errors when full, preventing unbounded host fd exhaustion from a malicious guestSocketTable::clear()which drains all sockets and resetsnext_idArc<Mutex<SocketTable>>throughSandboxsorestore()can clear it — fixes host-side fd leak across guest restore cycles (the guest "forgets" its sockets on memory rewind, but the host-side table previously retained them)evolve_inline,evolve_mapped,from_snapshot_file_fullTest plan
cargo test --lib net_socket_cap— verifies error at MAX_SOCKETS+1cargo test --lib socket_table_clear— verifies clear empties table and resets next_idcargo test --lib(50 tests) passescargo fmtandcargo clippyclean