fix: learn IPs from DNS responses to handle anycast rotation in AllowList - #56
Merged
Conversation
…List Signed-off-by: danbugs <danilochiarlone@gmail.com>
Contributor
There was a problem hiding this comment.
Linux Benchmarks
Details
| Benchmark suite | Current: 4c374d9 | Previous: c6128d7 | Ratio |
|---|---|---|---|
hello_world (median) |
20 ms |
20 ms |
1 |
pandas (median) |
110 ms |
110 ms |
1 |
density (per VM) |
7 MB |
7 MB |
1 |
snapshot (disk) |
385 MiB |
385 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Windows Benchmarks
Details
| Benchmark suite | Current: 4c374d9 | Previous: c6128d7 | Ratio |
|---|---|---|---|
hello_world (median) |
249 ms |
235 ms |
1.06 |
pandas (median) |
789 ms |
814 ms |
0.97 |
density (per VM) |
6 MB |
6 MB |
1 |
snapshot (disk) |
392 MiB |
392 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: danbugs <danilochiarlone@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AllowListnetworking policy, the guest resolves DNS via its own resolvers (e.g. 8.8.8.8) which may return different IPs than the host's resolver for the same hostname (due to anycast/CDN/geo-DNS rotation). The subsequentnet_connectto the guest-resolved IP was denied because it wasn't in the host-resolved allow set.net_recvfrom(port 53), parse A/AAAA answer records, and dynamically add resolved IPs to the AllowList when the queried hostname matches an allowed entry.mtime_nsandatime_nsto thefs_statresponse so guest-side VFS can expose real file timestamps (previously always returned 0).Details
Networking:
AllowListgains alearned_ips: Arc<Mutex<HashSet<IpAddr>>>fieldis_allowed()checkslearned_ipsin addition to the static set and re-resolutionlearn_ips_from_dns_response()is a minimal DNS response parser that extracts A (type 1) and AAAA (type 28) recordsFilesystem timestamps:
fs_statnow returnsmtime_nsandatime_ns(nanoseconds since epoch)lib/hostfschanges (in.unikraft/, gitignored) parse these fields and propagate tovattr— requires initrd rebuild to take effectTest plan
AllowListwithapi.github.com(previously failed due to DNS rotation)example.comstill works (regression check)os.stat()returns real timestampscargo test)