fix: add size caps to fs_read and net_send/net_sendto - #60
Merged
Conversation
Signed-off-by: danbugs <danilochiarlone@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Linux Benchmarks
Details
| Benchmark suite | Current: 3d13468 | Previous: 86d2609 | Ratio |
|---|---|---|---|
hello_world (median) |
20 ms |
20 ms |
1 |
pandas (median) |
110 ms |
110 ms |
1 |
density (per VM) |
7 MB |
7 MB |
1 |
snapshot (disk) |
385 MiB |
385 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Windows Benchmarks
Details
| Benchmark suite | Current: 3d13468 | Previous: 86d2609 | Ratio |
|---|---|---|---|
hello_world (median) |
301 ms |
245 ms |
1.23 |
pandas (median) |
979 ms |
725 ms |
1.35 |
density (per VM) |
6 MB |
6 MB |
1 |
snapshot (disk) |
392 MiB |
392 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs_readatMAX_FS_READ(16 MiB) via metadata check beforeread_to_string, matching the existing protection onfs_read_bytes— prevents guest-triggered host OOM from large filesMAX_NET_SEND(1 MiB) cap on decoded payload innet_sendandnet_sendtofor defense-in-depth parity with the recv cap (65 KiB)test_fs_read_size_capandtest_net_send_size_captestsTest plan
cargo test --libpasses (53 tests)cargo clippycleancargo fmtclean