fix: block loopback addresses by default in NetworkPolicy - #62
Merged
Conversation
Signed-off-by: danbugs <danilochiarlone@gmail.com>
There was a problem hiding this comment.
Pull request overview
Adds a defense-in-depth block of loopback addresses (127.0.0.0/8 and ::1) in NetworkPolicy::check(), mirroring the existing link-local block, so guests cannot reach host-local services regardless of policy variant.
Changes:
- In
NetworkPolicy::check(), reject any destination whose IP is a loopback address before evaluating the policy variant. - Add
net_loopback_blockedtest covering IPv4/IPv6 loopback under bothAllowAllandBlockListpolicies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Linux Benchmarks
Details
| Benchmark suite | Current: db5dc93 | Previous: 2c92788 | Ratio |
|---|---|---|---|
hello_world (median) |
20 ms |
20 ms |
1 |
pandas (median) |
100 ms |
110 ms |
0.91 |
density (per VM) |
7 MB |
7 MB |
1 |
snapshot (disk) |
385 MiB |
385 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Windows Benchmarks
Details
| Benchmark suite | Current: db5dc93 | Previous: 2c92788 | Ratio |
|---|---|---|---|
hello_world (median) |
248 ms |
187 ms |
1.33 |
pandas (median) |
782 ms |
545 ms |
1.43 |
density (per VM) |
6 MB |
6 MB |
1 |
snapshot (disk) |
392 MiB |
392 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
127.0.0.0/8and::1inNetworkPolicy::check()for all policy variants, usingaddr.ip().is_loopback()net_loopback_blockedtest covering both IPv4/IPv6 under AllowAll and BlockList policiesTest plan
cargo test --libpasses (54 tests)cargo clippycleancargo fmtclean