fix: cap AllowList learned_ips at 256 entries - #63
Merged
Conversation
Signed-off-by: danbugs <danilochiarlone@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR caps DNS-learned allowlist IPs to prevent unbounded memory growth when processing DNS responses for allowed hostnames.
Changes:
- Adds
MAX_LEARNED_IPSwith a 256-entry limit. - Updates
AllowList::learn_ipto stop inserting once the cap is reached. - Adds a unit test covering the learned IP cap.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #[test] | ||
| fn allowlist_learned_ips_capped() { | ||
| use std::net::{IpAddr, Ipv4Addr}; | ||
| let al = AllowList::from_hosts(&["example.com"]).unwrap(); |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Linux Benchmarks
Details
| Benchmark suite | Current: 740cd06 | Previous: 2c92788 | Ratio |
|---|---|---|---|
hello_world (median) |
20 ms |
20 ms |
1 |
pandas (median) |
100 ms |
110 ms |
0.91 |
density (per VM) |
7 MB |
7 MB |
1 |
snapshot (disk) |
385 MiB |
385 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Windows Benchmarks
Details
| Benchmark suite | Current: 740cd06 | Previous: 2c92788 | Ratio |
|---|---|---|---|
hello_world (median) |
291 ms |
187 ms |
1.56 |
pandas (median) |
1023 ms |
545 ms |
1.88 |
density (per VM) |
6 MB |
6 MB |
1 |
snapshot (disk) |
392 MiB |
392 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: danbugs <danilochiarlone@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
learned_ipsHashSet inAllowListat 256 entries to prevent unbounded memory growth from DNS response learningallowlist_learned_ips_cappedtest verifying the capTest plan
cargo test --libpasses (54 tests)cargo clippycleancargo fmtclean