Bump wasmparser from 0.244.0 to 0.245.1 (#1231)

* Bump wasmparser from 0.244.0 to 0.245.1

Dependabot couldn't find the original pull request head commit, f807128.

* Remove fetch-metadata

Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>

* chore: update guest Cargo.lock files

Automatically updated by dependabot-update-guest-locks workflow.
Triggered by: Bump wasmparser from 0.244.0 to 0.245.1

Signed-off-by: dependabot-pr-auto-approver[bot] <207571483+dependabot-pr-auto-approver[bot]@users.noreply.github.com>

* fix: update for wasmparser 0.245.1 API changes

- ComponentDefinedType::FixedSizeList renamed to FixedLengthList
- VariantCase::refines field was removed from wasmparser

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>

---------

Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Signed-off-by: dependabot-pr-auto-approver[bot] <207571483+dependabot-pr-auto-approver[bot]@users.noreply.github.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Co-authored-by: dependabot-pr-auto-approver[bot] <207571483+dependabot-pr-auto-approver[bot]@users.noreply.github.com>
Co-authored-by: James Sturtevant <jsturtevant@gmail.com>

Author: 4 people

.github/workflows/ValidatePullRequest.yml

@@ -46,9 +46,7 @@ jobs:
   # Cargo.lock files stale. This job updates them before code-checks runs
   # `cargo fetch --locked` so that the first CI run succeeds.
   update-guest-locks:
-    if: >-
-      github.event.pull_request.user.login == 'dependabot[bot]' &&
-      github.actor == 'dependabot[bot]'
+    if: github.event.pull_request.user.login == 'dependabot[bot]'
     uses: ./.github/workflows/dep_update_guest_locks.yml
     secrets: inherit
 

.github/workflows/dep_update_guest_locks.yml

@@ -16,7 +16,6 @@ env:
 
 permissions:
   contents: read
-  pull-requests: read
 
 defaults:
   run:
@@ -27,28 +26,9 @@ jobs:
     runs-on: [self-hosted, Linux, X64, "1ES.Pool=hld-kvm-amd"]
     timeout-minutes: 15
     steps:
-      # Fetch metadata about the Dependabot PR
-      - name: Dependabot metadata
-        id: metadata
-        uses: dependabot/fetch-metadata@v2
-        with:
-          github-token: "${{ secrets.GITHUB_TOKEN }}"
-
-      # Only proceed for cargo ecosystem updates
-      - name: Check if cargo update
-        id: check-ecosystem
-        run: |
-          if [ "${{ steps.metadata.outputs.package-ecosystem }}" = "cargo" ]; then
-            echo "is_cargo=true" >> "$GITHUB_OUTPUT"
-          else
-            echo "is_cargo=false" >> "$GITHUB_OUTPUT"
-            echo "Skipping non-cargo dependency update"
-          fi
-
       # Get GitHub App token for pushing commits back to the PR
       # Uses the same app as auto-merge-dependabot.yml
       - name: Get GitHub App token
-        if: steps.check-ecosystem.outputs.is_cargo == 'true'
         uses: actions/create-github-app-token@v2
         id: get-app-token
         with:
@@ -57,7 +37,6 @@ jobs:
           permission-contents: write
 
       - name: Checkout PR branch
-        if: steps.check-ecosystem.outputs.is_cargo == 'true'
         uses: actions/checkout@v6
         with:
           token: ${{ steps.get-app-token.outputs.token }}
@@ -66,30 +45,25 @@ jobs:
           persist-credentials: false
 
       - name: Setup Rust toolchain
-        if: steps.check-ecosystem.outputs.is_cargo == 'true'
         uses: hyperlight-dev/ci-setup-workflow@v1.8.0
         with:
           rust-toolchain: "1.89"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Fix cargo home permissions
-        if: steps.check-ecosystem.outputs.is_cargo == 'true'
         run: |
           sudo chown -R $(id -u):$(id -g) /opt/cargo || true
 
       - name: Update simpleguest Cargo.lock
-        if: steps.check-ecosystem.outputs.is_cargo == 'true'
         working-directory: src/tests/rust_guests/simpleguest
         run: cargo fetch
 
       - name: Update dummyguest Cargo.lock
-        if: steps.check-ecosystem.outputs.is_cargo == 'true'
         working-directory: src/tests/rust_guests/dummyguest
         run: cargo fetch
 
       - name: Update witguest Cargo.lock
-        if: steps.check-ecosystem.outputs.is_cargo == 'true'
         working-directory: src/tests/rust_guests/witguest
         run: cargo fetch
 
@@ -105,11 +79,10 @@ jobs:
       # - Git Data API (Create a commit):
       #   https://docs.github.com/en/rest/git/commits#create-a-commit
       - name: Commit and push changes via API
-        if: steps.check-ecosystem.outputs.is_cargo == 'true'
         env:
           GH_TOKEN: ${{ steps.get-app-token.outputs.token }}
           APP_SLUG: ${{ steps.get-app-token.outputs.app-slug }}
-          DEPENDENCY_NAMES: ${{ steps.metadata.outputs.dependency-names }}
+          PR_TITLE: ${{ github.event.pull_request.title }}
           BRANCH: ${{ github.head_ref }}
           REPO: ${{ github.repository }}
         run: |
@@ -157,7 +130,7 @@ jobs:
           COMMIT_MSG=$(printf '%s\n\n%s\n%s\n\n%s' \
             "chore: update guest Cargo.lock files" \
             "Automatically updated by dependabot-update-guest-locks workflow." \
-            "Triggered by: ${DEPENDENCY_NAMES}" \
+            "Triggered by: ${PR_TITLE}" \
             "Signed-off-by: ${SIGNOFF}")
 
           # Create commit via API — GitHub signs it automatically since we

Cargo.lock

@@ -16,7 +16,7 @@ name = "hyperlight_component_macro"
 proc-macro = true
 
 [dependencies]
-wasmparser = { version = "0.244.0" }
+wasmparser = { version = "0.245.1" }
 quote = { version = "1.0.44" }
 proc-macro2 = { version = "1.0.106" }
 syn = { version = "2.0.117" }

src/hyperlight_component_macro/Cargo.toml

@@ -15,7 +15,7 @@ Shared implementation for the procedural macros that generate Hyperlight host an
 name = "hyperlight_component_util"
 
 [dependencies]
-wasmparser = { version = "0.244.0" }
+wasmparser = { version = "0.245.1" }
 quote = { version = "1.0.44" }
 proc-macro2 = { version = "1.0.106" }
 syn = { version = "2.0.117" }

src/hyperlight_component_util/Cargo.toml

@@ -402,7 +402,6 @@ impl<'p, 'a> Ctx<'p, 'a> {
                         Ok(VariantCase {
                             name: Name { name: vc.name },
                             ty: vc.ty.as_ref().map(|ty| self.elab_value(ty)).transpose()?,
-                            refines: vc.refines,
                         })
                     })
                     .collect::<Result<Vec<_>, Error<'a>>>()?;
@@ -433,7 +432,7 @@ impl<'p, 'a> Ctx<'p, 'a> {
                 Defined::Handleable(h) => Ok(Value::Borrow(h.clone())),
                 _ => Err(Error::HandleToNonResource),
             },
-            ComponentDefinedType::FixedSizeList(vt, size) => {
+            ComponentDefinedType::FixedLengthList(vt, size) => {
                 Ok(Value::FixList(Box::new(self.elab_value(vt)?), *size))
             }
             ComponentDefinedType::Future(_) | ComponentDefinedType::Stream(_) => {

src/hyperlight_component_util/src/elaborate.rs

@@ -70,7 +70,6 @@ pub struct RecordField<'a> {
 pub struct VariantCase<'a> {
     pub name: Name<'a>,
     pub ty: Option<Value<'a>>,
-    pub refines: Option<u32>,
 }
 
 /// valtype_e in the specification

src/hyperlight_component_util/src/etypes.rs

@@ -77,7 +77,6 @@ where
                 Ok(VariantCase {
                     name: vc.name,
                     ty: self.value_option(&vc.ty)?,
-                    refines: vc.refines,
                 })
             })
             .collect()

src/hyperlight_component_util/src/substitute.rs

@@ -117,13 +117,6 @@ pub enum Error<'a> {
     DuplicateRecordField(Name<'a>),
     /// A variant has multiple cases with the same name
     DuplicateVariantField(Name<'a>),
-    /// A variant case is marked as refining another case, but that
-    /// case does not exist
-    NonexistentVariantRefinement(u32),
-    /// A variant case is marked as refining another case, but its
-    /// associated value is not a subtype of the value of the refined
-    /// case
-    IncompatibleVariantRefinement(subtype::Error<'a>),
     /// A flags has multiple flags with the same name
     DuplicateFlagsName(Name<'a>),
     /// An enum has multiple cases with the same name
@@ -181,15 +174,6 @@ impl<'p, 'a> Ctx<'p, 'a> {
             |&vc| vc.name.name,
             |vc| Error::DuplicateVariantField(vc.name),
         )?;
-        for vc in vcs {
-            if let Some(ri) = vc.refines {
-                let rvc = vcs
-                    .get(ri as usize)
-                    .ok_or(Error::NonexistentVariantRefinement(ri))?;
-                self.subtype_value_option(&vc.ty, &rvc.ty)
-                    .map_err(Error::IncompatibleVariantRefinement)?;
-            }
-        }
         Ok(())
     }
     fn wf_value<'r>(&'r self, p: ValueTypePosition, vt: &'r Value<'a>) -> Result<(), Error<'a>> {