Save an unconditional clone of guest parameters

Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>

Author: ludfjig

src/hyperlight_guest_bin/src/guest_function/call.rs

@@ -27,7 +27,7 @@ use tracing::{Span, instrument};
 
 use crate::{GUEST_HANDLE, REGISTERED_GUEST_FUNCTIONS};
 
-type GuestFunc = fn(&FunctionCall) -> Result<Vec<u8>>;
+type GuestFunc = fn(FunctionCall) -> Result<Vec<u8>>;
 
 #[instrument(skip_all, parent = Span::current(), level= "Trace")]
 pub(crate) fn call_guest_function(function_call: FunctionCall) -> Result<Vec<u8>> {
@@ -64,7 +64,7 @@ pub(crate) fn call_guest_function(function_call: FunctionCall) -> Result<Vec<u8>
             core::mem::transmute::<usize, GuestFunc>(function_pointer)
         };
 
-        p_function(&function_call)
+        p_function(function_call)
     } else {
         // The given function is not registered. The guest should implement a function called guest_dispatch_function to handle this.
 

src/hyperlight_guest_bin/src/guest_function/definition.rs

@@ -41,7 +41,7 @@ pub struct GuestFunctionDefinition {
     pub function_pointer: usize,
 }
 
-/// Trait for functions that can be converted to a `fn(&FunctionCall) -> Result<Vec<u8>>`
+/// Trait for functions that can be converted to a `fn(FunctionCall) -> Result<Vec<u8>>`
 #[doc(hidden)]
 pub trait IntoGuestFunction<Output, Args>
 where
@@ -53,8 +53,8 @@ where
     #[doc(hidden)]
     const ASSERT_ZERO_SIZED: ();
 
-    /// Convert the function into a `fn(&FunctionCall) -> Result<Vec<u8>>`
-    fn into_guest_function(self) -> fn(&FunctionCall) -> Result<Vec<u8>>;
+    /// Convert the function into a `fn(FunctionCall) -> Result<Vec<u8>>`
+    fn into_guest_function(self) -> fn(FunctionCall) -> Result<Vec<u8>>;
 }
 
 /// Trait for functions that can be converted to a `GuestFunctionDefinition`
@@ -124,14 +124,14 @@ macro_rules! impl_host_function {
                 assert!(core::mem::size_of::<Self>() == 0)
             };
 
-            fn into_guest_function(self) -> fn(&FunctionCall) -> Result<Vec<u8>> {
-                |fc: &FunctionCall| {
+            fn into_guest_function(self) -> fn(FunctionCall) -> Result<Vec<u8>> {
+                |fc: FunctionCall| {
                     // SAFETY: This is safe because:
                     //  1. F is zero-sized (enforced by the ASSERT_ZERO_SIZED const).
                     //  2. F has no Drop impl (enforced by the Copy bound).
                     // Therefore, creating an instance of F is safe.
                     let this = unsafe { core::mem::zeroed::<F>() };
-                    let params = fc.parameters.clone().unwrap_or_default();
+                    let params = fc.parameters.unwrap_or_default();
                     let params = <($($P,)*) as ParameterTuple>::from_value(params)?;
                     let result = Function::<R::ReturnType, ($($P,)*), HyperlightGuestError>::call(&this, params)?;
                     Ok(into_flatbuffer_result(result.into_value()))