Add journal retention period mgmt (#442)

* Add journal retention period mgmt

* Drop spread operator syntax

Author: ad-m

bin/generic/update/replace/index.js

@@ -2,7 +2,10 @@
 const Cli = require('lib/cli');
 
 module.exports = (resource, field_name) => {
-    const parameter = resource.schema[field_name];
+    const parameter = Object.assign({},
+        resource.schema[field_name],
+        { required: true }
+    );
 
     const name = parameter.name || field_name;
 

bin/journal/index.js

@@ -23,6 +23,7 @@ const schema = {
         required: false,
         defaultValue: 90,
         onCreate: true,
+        onUpdate: true,
     },
     credentials: {
         virtual: true,
@@ -31,15 +32,14 @@ const schema = {
     tags: {
         virtual: true,
         onCreate: true,
-        onUpdate: true,
     },
 };
 
 const resource = {
     name: 'journal',
     apiName: 'journal',
     defaultQuery: '[].{id:id,name:name,retention:retention,sizeUsed:sizeUsed,state:state,processing:processing}',
-    commands: ['show', 'delete', 'rename', 'create', 'list', 'history', 'tag', 'service', 'transfer', 'credential'],
+    commands: ['show', 'delete', 'rename', 'create', 'list', 'history', 'tag', 'service', 'transfer', 'update', 'credential'],
     plugins: genericDefaults.plugins,
     url: () => 'journal',
     dirname: __dirname,

bin/journal/tests.js

@@ -23,7 +23,7 @@ ava.serial('journal logger & stream', async t => {
     const content = await tests.getToken();
     const log_file = tests.getRandomFile(content);
     const output_file = tests.randomFileName();
-    const journal = await tests.run(`journal create --name log-logger-${now}`);
+    const journal = await tests.run(`journal create --name ${tests.getName(t.title)}`);
     try {
         await tests.run(`journal credential password add --journal ${journal.id} --name my-token --password ${token}`);
         await tests.run(`journal logger --journal ${journal.id} --token ${token} --log-file ${log_file}`);
@@ -45,7 +45,7 @@ ava.serial('journal logger & stream with tags', async t => {
     const content_without_tag = await tests.getToken();
     const log_file_without_tag = tests.getRandomFile(content_without_tag);
     const output_file = tests.randomFileName();
-    const journal = await tests.run(`journal create --name log-logger-${now} --password ${token}`);
+    const journal = await tests.run(`journal create --name ${tests.getName(t.title)} --password ${token}`);
     try {
         await tests.run(`journal logger --journal ${journal.id} --token ${token} --log-file ${log_file_with_tag} --tag host=123`);
         await tests.run(`journal logger --journal ${journal.id} --token ${token} --log-file ${log_file_without_tag}`);
@@ -60,3 +60,15 @@ ava.serial('journal logger & stream with tags', async t => {
         await tests.remove('journal', journal);
     }
 });
+
+ava.serial('journal retention update', async t => {
+    const journal = await tests.run(`journal create --name ${now} --retention 25`);
+    try {
+        t.true(journal.retention === 25);
+        await tests.run(`journal retention --journal ${journal.id} --retention 25`);
+        const journal_updated = await tests.run(`journal show --journal ${journal.id}`);
+        t.true(journal_updated.retention === 25);
+    } finally {
+        await tests.remove('journal', journal);
+    }
+});

docs/journal.md

@@ -10,6 +10,7 @@
     * [h1 journal service list](#h1-journal-service-list) - List Service for Journal
     * [h1 journal service show](#h1-journal-service-show) - Show Service for Journal
   * [h1 journal transfer](#h1-journal-transfer) - Transfer Journal to other project
+  * [h1 journal retention](#h1-journal-retention) - Update Data retention period (in days) of Journal
   * [h1 journal stream](#h1-journal-stream) - Stream or read messages of Journal
   * [h1 journal logger](#h1-journal-logger) - Log messages to Journal
   * [h1 journal credential](#h1-journal-credential) - Manage your credentials of Journal
@@ -248,6 +249,20 @@ h1 journal transfer --journal test-journal --new-project OtherProject
 | ```--journal JOURNAL``` |  | Journal ID or name |
 | ```--new-project NEW-PROJECT``` |  | New name |
 
+## h1 journal retention
+
+Update Data retention period (in days) of Journal
+
+### Syntax
+
+```h1 journal retention | --retention RETENTION --journal JOURNAL```
+### Required arguments
+
+| Name | Default | Description |
+| ---- | ------- | ----------- |
+| ```--retention RETENTION``` |  | Data retention period (in days) |
+| ```--journal JOURNAL``` |  | Journal ID or name |
+
 ## h1 journal stream
 
 Stream or read messages of Journal

lib/tests.js

@@ -494,7 +494,7 @@ const get = (url) => {
 
 const runProcess = (cmd, opts = {}) => new Promise((resolve, reject) => {
     const argv = shell_quote.parse(cmd);
-
+    console.log(new Date(), 'local:', cmd);
     const proc = spawn(argv[0], argv.slice(1), {
         env: Object.assign({}, process.env, opts.env),
         stdio: [null, 'pipe', 'pipe'],